Revert "When services share IP, modifying any service should fail #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aea1881. The meaning of the annotation is that MetalLB _may_ colocate the two services sharing the same IP, but it's a best effort indication. If the two services are incompatible (i.e. they have different external traffic policies), they won't get the same IP and they should not. This also fixes a bug where: - the controller is stopped - a service without an external ip is created - a service with an external ip is already present - the controller is started If the controller processes the service without IP first, it may get the first available IP (because metallb doesn't know the allocation yet), but when the second service is processed, instead of getting a new IP because it is not compatible with the first processed service, the controller silently fail and the service holds the same IP as the other, even if no request of sharing through the annotation were made.
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
fedepaol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit aea1881.
The meaning of the annotation is that MetalLB may colocate the two services sharing the same IP, but it's a best effort indication. If the two services are incompatible (i.e. they have different external traffic policies), they won't get the same IP and they should not. This also fixes a bug where:
If the controller processes the service without IP first, it may get the first available IP (because metallb doesn't know the allocation yet), but when the second service is processed, instead of getting a new IP because it is not compatible with the first processed service, the controller silently fail and the service holds the same IP as the other, even if no request of sharing through the annotation were made.
Fixes #1591