Start the metrics after the webhook is ready #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
fedepaol
force-pushed
the
fix/startmetricsafterwebhooks
branch
from
b599893 to
2aeceba
Compare
fedepaol
changed the title
The metrics serve as readiness probe. Helm wait checks for the pods to be ready, and by doing this we ensure that the metric endpoint accepts requests only after the webhook is ready to serve requests. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
This reverts commit 6d208de. The workaround works and now helm waits is able to wait for the webhook to be ready, but the controller logs are full of errors like "unable to process a request with an unknown content type".
fedepaol
force-pushed
the
fix/startmetricsafterwebhooks
branch
from
2aeceba to
57f8342
Compare
This reverts commit 9ea03f0. Reverting to restore the readiness probe to hit the metrics endpoint.
|
Also, tried manually the steps described in #1610 : helm install metallb metallb/metallb --wait --namespace metallb-system
kubectl apply -f configsamples/bgppeer_simple.yamlAnd it didn't fail |
|
LGTM |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1644
Revert the change of readiness probe, and change the webhook to start the metrics endpoint only after the webhooks are patched properly and thus able to serve.