Helm: handle the addressPoolUsage.enabled flag#1688
Merged
fedepaol merged 2 commits intometallb:mainfrom Nov 24, 2022
buker:1687-fix-prometheus-alerts
Merged
Helm: handle the addressPoolUsage.enabled flag#1688fedepaol merged 2 commits intometallb:mainfrom buker:1687-fix-prometheus-alerts
fedepaol merged 2 commits intometallb:mainfrom
buker:1687-fix-prometheus-alerts
Conversation
buker
requested review from
fedepaol,
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
Member
|
Hi, thanks for the PR! |
Member
|
That aside, the pr looks good. Thanks! |
The flag is available in the values but it is not handled by the charts. Here we set the thresholds only if the flag is raised.
fedepaol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #1687