Implement ip pool selector logic for service#1693
Merged
fedepaol merged 2 commits intometallb:mainfrom Dec 13, 2022
Merged
Conversation
pperiyasamy
requested review from
fedepaol,
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
from
e25b8ec to
3413c0f
Compare
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
from
3413c0f to
c9d19db
Compare
fedepaol
reviewed
Nov 23, 2022
controller/main.go
Outdated
| pools map[string]*config.Pool | ||
| ips *allocator.Allocator | ||
| client service | ||
| pools map[string]*config.Pool |
Member
There was a problem hiding this comment.
Can we have a local higher level struct that wraps all the pools (pools itself plus the selectors)? In that way, we can have it expose methods too
Contributor
Author
There was a problem hiding this comment.
sure, moved this higher level struct into config and consuming it in every places.
controller/service.go
Outdated
| return ips, nil | ||
| } | ||
|
|
||
| pinnedPriorityPools, pinnedNoPriorityPools := c.getPinnedPools(svc) |
Member
There was a problem hiding this comment.
I'd move all this logic to allocator's Allocate()
Contributor
Author
There was a problem hiding this comment.
yes, this is a cleaner solution. moved the logic into Allocate().
| For(&metallbv1beta1.IPAddressPool{}). | ||
| Watches(&source.Kind{Type: &metallbv1beta1.AddressPool{}}, &handler.EnqueueRequestForObject{}). | ||
| Watches(&source.Kind{Type: &metallbv1beta1.Community{}}, &handler.EnqueueRequestForObject{}). | ||
| Watches(&source.Kind{Type: &corev1.Namespace{}}, &handler.EnqueueRequestForObject{}). |
Member
There was a problem hiding this comment.
We need a predicate that discard events on the namespace that do not involve changing labels.
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
3 times, most recently
from
9d79fbb to
e847f37
Compare
fedepaol
reviewed
Nov 29, 2022
Contributor
|
hint for static-security-analysis, |
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
from
e847f37 to
10497dd
Compare
Contributor
Author
Can you also make this available from inv command via tasks.py ? |
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
2 times, most recently
from
e1aee19 to
dea0efb
Compare
fedepaol
reviewed
Dec 5, 2022
fedepaol
reviewed
Dec 5, 2022
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
from
dea0efb to
4c79d4c
Compare
fedepaol
reviewed
Dec 5, 2022
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
2 times, most recently
from
b67ff14 to
943c04c
Compare
fedepaol
reviewed
Dec 6, 2022
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
3 times, most recently
from
6f51119 to
2f4e14d
Compare
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
from
2f4e14d to
35ea87e
Compare
This changes ip allocation logic when ip pools are configured with namespace, service/namespace label selectors so that ip are allocated from desired pools based on its priority before it tries to allocate from other ip pools. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
from
35ea87e to
5e3a147
Compare
This adds relevant e2e tests covering functionality of ip pools pinned with specific namespace and/or service labels. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
ippool-selector-impl
branch
from
5e3a147 to
38ab7e2
Compare
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes ip allocation logic when ip pools are configured with namespace, service/namespace label selectors so that ip are allocated from desired pools based on its priority before it tries to allocate from other ip pools.
Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com