Add support for BGP large communities #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskaris
requested review from
fedepaol,
gclawes,
oribon,
rata and
russellb
as code owners
andreaskaris
force-pushed
the
large-communities
branch
9 times, most recently
from
778e0cd to
7d3059f
Compare
andreaskaris
changed the title
andreaskaris
force-pushed
the
large-communities
branch
2 times, most recently
from
9829776 to
95ebb50
Compare
fedepaol
reviewed
Apr 21, 2023
andreaskaris
force-pushed
the
large-communities
branch
3 times, most recently
from
07fe14d to
7784aeb
Compare
fedepaol
reviewed
Apr 28, 2023
andreaskaris
force-pushed
the
large-communities
branch
3 times, most recently
from
992342c to
d172845
Compare
Contributor
Author
|
I moved the removal of native_test.go to #1915 ; |
andreaskaris
force-pushed
the
large-communities
branch
from
d172845 to
c079bf9
Compare
fedepaol
reviewed
Apr 28, 2023
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
andreaskaris
force-pushed
the
large-communities
branch
from
c079bf9 to
1a6edd9
Compare
andreaskaris
force-pushed
the
large-communities
branch
from
1a6edd9 to
d8a3414
Compare
This patch only implements large communities but the format is compatible with a future implementation of extended communities. Community types are distinguished by using Juniper style syntax, thus <AS number>:<community value>,<type>:<administrator>:<assigned-number>, large:<global administrator>:<localdata part 1>:<localdata part 2> for each of the respective types legacy, extended and large communities. Also update CRD descriptions for large communities Signed-off-by: Andreas Karis <ak.karis@gmail.com>
andreaskaris
force-pushed
the
large-communities
branch
from
d8a3414 to
5b995ad
Compare
Contributor
Author
|
Made one last change to an error message: https://github.com/metallb/metallb/compare/d8a34145cd219e1851542573dee74ab521e3fb0d..5b995adda290bbf25dac0ef7553d6597296a4bd9 |
Member
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch only implements large communities but the format is compatible with a future implementation of extended communities.
Community types are distinguished by using Juniper style syntax, thus :,::, large::<localdata part 1>:<localdata part 2> for each of the respective types legacy, extended and large communities.
Implements https://issues.redhat.com/browse/RFE-3924