WIP: Remove metallb-system namespace #194
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a first draft of how to remove the hardcoded
metallb-system
namespace and make metallb namespace-agnostic.InClusterNamespace
tointernal/k8s/
to detect the namespace the pod is currently running in--config-ns
parameter.manifests/
to use the default namespace. This is just as POC we might just keep themetallb-namespace
in there - it does not matter with the changes anymore. I did not update the helm chart because it will probably be maintained in kubernetes/charts in the near future.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #193
Special notes for your reviewer:
Please elaborate on why the--config-ns
parameter is necessary. Should the metallb controller be able to run outside of cluster? I can not think of any other scenarios. If this is not the case, it should probably be removed and default to namespace metallb is running in.