Trigger reprocessall event only when an ip has been unassigned #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlguerrero12
requested review from
fedepaol,
gclawes,
oribon,
rata and
russellb
as code owners
fedepaol
reviewed
May 19, 2023
controller/main.go
Outdated
| // we delete a balancer we should reprocess all of them to | ||
| // check for newly feasible balancers. | ||
| return controllers.SyncStateReprocessAll | ||
| if c.ips.Unassign(name) { |
Member
There was a problem hiding this comment.
Can we have a "IsAllocated" function on the allocator and have it guarding this if? In this way it is going to be clearer why we do the reprocessall (as opposed to having to rely on the fact that unassign returns false if the service is not there).
The effect would be the same but this function would be easier to understand.
Author
There was a problem hiding this comment.
Done. More expensive to run tough.
Member
There was a problem hiding this comment.
Agree, but I prefer to prioritize the codebase to be maintainable / readable rather than optimized. And this is not a bottleneck anyway.
Member
|
Nice catch! |
mlguerrero12
force-pushed
the
preventreprocessall
branch
from
f5d0391 to
fc1960e
Compare
This prevents the unnecessary reprocess of all services when a service with no LB IP assigned is deleted. Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
mlguerrero12
force-pushed
the
preventreprocessall
branch
from
fc1960e to
f9dda2d
Compare
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the unnecessary reprocess of all services when a service with no LB IP assigned is deleted.