fix: add missing namespace to helm chart templates#1965
Merged
Conversation
ankitm123
requested review from
fedepaol,
gclawes,
oribon,
rata and
russellb
as code owners
ankitm123
force-pushed
the
ankitm123.GH-1964
branch
from
2296f69 to
9dc07de
Compare
Member
|
Mind expanding the commit message why we need this and |
Member
|
Can you handle also the other resources? Such as service monitors / podmonitors / prometheusrules for example |
Contributor
Author
|
I will update the PR this weekend. |
ankitm123
force-pushed
the
ankitm123.GH-1964
branch
from
9dc07de to
d4f0f3f
Compare
Helm template, unlike helm install, does not set the namespace for namespaced resources. This inconsistency creates issues for users who use helm template to generate the manifests, and then use other tools to apply the manifests (kubectl, terraform, argo etc) A workaround is to add the namespace field to the metadata section. Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
ankitm123
force-pushed
the
ankitm123.GH-1964
branch
from
d4f0f3f to
53297d8
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1964