Repository navigation
Adding frrk8s deployment method to helm - #2183
Merged
Merged
Conversation
fedepaol
force-pushed
the
helmfrrk8s
branch
12 times, most recently
from
November 30, 2023 09:12
ed6a8b4 to
81e1bc7
Compare
oribon
reviewed
Nov 30, 2023
| enabled: true | ||
| validationFailurePolicy: Fail | ||
|
|
||
| frrk8s: |
Member
There was a problem hiding this comment.
can you add a short comment about what this is about + that it is mutually exclusive with frr mode?
| - name: Check if deps are updated | ||
| run: | | ||
| helm repo add frrk8s https://metallb.github.io/frr-k8s | ||
| helm dependency update charts/metallb |
Member
Author
There was a problem hiding this comment.
yep, related to the version we have declared. So if there's as skew, CI will cry
Adding a deployment mode where we deploy the external frr-k8s and we set the proper parameters / permissions. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Setting the right helm values when deploying frr-k8s Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Adding a lane that deploys frrk8s + helm Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Using the official gh action, allows do add the external chart. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
This is a change introduced by the helm conftest bump Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending the charts / CI / tasks to support frrk8s via helm