Remove support for legacy AddressPools - #2252
Merged
Merged
Conversation
fedepaol
reviewed
Jan 18, 2024
| - Squash the prefixes in FRR mode, avoiding duplicate prefixes in the FRR configuration ([PR 2234](https://github.com/metallb/metallb/pull/2234)) | ||
|
|
||
| - BGP: move the matching peer logic one level up ([PR 2233](https://github.com/metallb/metallb/pull/2233)) | ||
| - Remove support for legacy AddressPools ([PR 2252](https://github.com/metallb/metallb/pull/2252)) |
Member
There was a problem hiding this comment.
Can you be a bit more verbose here on what we are removing? Also, I'd move it to the features section so it's more evident.
Being deprecated for a while, we finally delete the old API in favor of supporting only IPAddressPools. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Now that the API is removed we delete all the references to it. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Now that we don't handle the legacy AddressPools we remove all of its test cases. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
Now that we no longer support legacy AddressPools we don't need this lane. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
oribon
force-pushed
the
remove_addresspools
branch
from
January 21, 2024 08:30
9305d02 to
23a9554
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy AddressPool API has been deprecated for a while, we finally delete it in favor of supporting only IPAddressPools.