Skip to content

modify kustomization.yaml#516

Merged
danderson merged 1 commit intometallb:mainfrom
binoue:modify-kustomize
Mar 17, 2020
Merged

modify kustomization.yaml#516
danderson merged 1 commit intometallb:mainfrom
binoue:modify-kustomize

Conversation

@binoue
Copy link
Copy Markdown
Contributor

@binoue binoue commented Jan 6, 2020

Metallb is now using kustomize to generate Kubernetes resource files since v0.8.3

I noticed that in the manifest directory both namespace.yaml and metallb.yaml contain the same namespace resource, but metallb.yaml does not need the namespace resource if kustomization.yaml merge both files.

It does not only reduce codes but also beneficial for the users who want to use metallb resources in a different namespace.
(They do not need to edit the upsteam yaml file and only need to edit kustomization.yaml)

Therefore, this pull request made the following changes.

  • delete namespace resource from metallb.yaml
  • modify kustomization.yaml to merge metallb.yaml and namespace.yaml

@danderson
Copy link
Copy Markdown
Contributor

Thanks!

@danderson danderson merged commit 514091a into metallb:main Mar 17, 2020
@johananl johananl mentioned this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants