Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify kustomization.yaml #516

Merged
merged 1 commit into from Mar 17, 2020
Merged

Conversation

binoue
Copy link
Contributor

@binoue binoue commented Jan 6, 2020

Metallb is now using kustomize to generate Kubernetes resource files since v0.8.3

I noticed that in the manifest directory both namespace.yaml and metallb.yaml contain the same namespace resource, but metallb.yaml does not need the namespace resource if kustomization.yaml merge both files.

It does not only reduce codes but also beneficial for the users who want to use metallb resources in a different namespace.
(They do not need to edit the upsteam yaml file and only need to edit kustomization.yaml)

Therefore, this pull request made the following changes.

  • delete namespace resource from metallb.yaml
  • modify kustomization.yaml to merge metallb.yaml and namespace.yaml

@danderson
Copy link
Contributor

danderson commented Mar 17, 2020

Thanks!

@danderson danderson merged commit 514091a into metallb:main Mar 17, 2020
1 check passed
@johananl johananl mentioned this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants