Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Metallb is now using
kustomize
to generate Kubernetes resource files since v0.8.3I noticed that in the manifest directory both
namespace.yaml
andmetallb.yaml
contain the same namespace resource, butmetallb.yaml
does not need the namespace resource ifkustomization.yaml
merge both files.It does not only reduce codes but also beneficial for the users who want to use
metallb
resources in a different namespace.(They do not need to edit the upsteam yaml file and only need to edit
kustomization.yaml
)Therefore, this pull request made the following changes.
metallb.yaml
kustomization.yaml
to mergemetallb.yaml
andnamespace.yaml