-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layer2 not arping when IP changes #520
Conversation
@danderson are you the appropriate person to request a review from? |
@daxmc99 ? |
Thanks for the contribution @KnicKnic, I will try to review this later in the week. |
@daxmc99 ping for an updated eta :-) |
Hi @KnicKnic, |
090428c
to
c5166d9
Compare
SetBalancer in Announcer.go essentially short circuits if the load balancer is already set. The fix just deletes the existing balancer for the service and allows it to fall through and create a new one with the new IP.
c5166d9
to
ecb5ee6
Compare
@daxmc99 |
I am seeing the rebase and merge option available again in the GitHub UI so what you did worked 👍 |
This change isn't strictly necessary but the newer versions of metallb contain some really nice quality of life improvements, and better support newer (installed by default) versions of kubernetes better. A sample of some improvements this brings to metallb add-on installed by minikube: - [Layer2 doesn't update when when ip changes](metallb/metallb#520) - this hit me, and might be hitting others - [Allow spaces in configs](metallb/metallb#500) - quality of life - [selflink is deprecated](metallb/metallb#812) - Kubernetes deprecation (I believe seeing this is in the logs is what originally caused me to look into upgrading it)
Fixed #471
I noticed that SetBalancer in Announcer.go essentially short circuits if the load balancer is already set. I also saw that it was cached in main.go of the speaker for the service.
So to fix this, I just deleted the existing balancer for the service and allowed it to fall through and create a new one with the new IP.