Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Installation by manifest script #557

Merged
merged 1 commit into from Mar 23, 2020

Conversation

Henry-Kim-Youngwoo
Copy link
Contributor

@Henry-Kim-Youngwoo Henry-Kim-Youngwoo commented Mar 23, 2020

since v9.0 because of kustomize "metallb.yaml" doesn't have namespace spec
before apply metallb.yaml should apply namespace.yaml first
Installation page is for new user and someone just copy and paste tutorial
before v9.0 tutorial works fine
after v9.0 user will see namespace not found error
please check my PR

since v9.0 because of kustomize "metallb.yaml" doesn't have namespace spec
before apply metallb.yaml should apply namespace.yaml first
rata
rata approved these changes Mar 23, 2020
Copy link
Member

@rata rata left a comment

LGTM, thanks!

@rata rata merged commit f04afd7 into metallb:main Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants