Add ml-bindport / METALLB_ML_BIND_PORT config#582
Merged
Conversation
rata
reviewed
Apr 14, 2020
Contributor
Author
|
@rata done |
rata
approved these changes
Apr 14, 2020
Contributor
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, but haven't tested it at all.
Have you tested it manually? :)
Contributor
Author
|
nop, not tested yet |
Contributor
|
@champtar please ping me when it's ready to merge (if you don't have permissions) :) |
Contributor
Author
|
Just tested, it works ! |
Contributor
|
@champtar cool! Yes, adding it to the manifest commented out (maybe a comment explaining and saying it is not usually needed or something?) sounds great! :) |
Docker EE already uses port 7946 (likely memberlist) Fixes metallb#581 Signed-off-by: Etienne Champetier <echampetier@anevia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker EE already uses port 7946 (likely memberlist)
Fixes #581