Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-kit log.NewStdlibAdapter instead of our own adapter #587

Merged
merged 1 commit into from Apr 28, 2020

Conversation

champtar
Copy link
Contributor

@champtar champtar commented Apr 17, 2020

New log looks like:
{"caller":"net.go:785","component":"MemberList","msg":"[DEBUG] memberlist: Initiating push/pull sync with: 10.11.12.13:7946","ts":"2020-04-17T00:31:37.51568936Z"}

@champtar
Copy link
Contributor Author

champtar commented Apr 17, 2020

@rata this PR was tested ;)

@rata
Copy link
Member

rata commented Apr 19, 2020

@champtar thanks! I guess the caller field is not very useful? Is it the file in the memberlist code?

Can you please add in the commit message too how the output looked before this patch too?

Other than that, LGTM. But please, if you think it makes sense too, add how the logs looked like before this patch :)

@champtar
Copy link
Contributor Author

champtar commented Apr 20, 2020

caller is the file/line in the memberlist code yes (StdlibAdapter is doing some parsing), I can remove it (golog.Lshortfile)
I'll add the previous output to the commit message

@rata
Copy link
Member

rata commented Apr 24, 2020

Don't hesitate to ping me when ready :)

@champtar
Copy link
Contributor Author

champtar commented Apr 24, 2020

crazy week, I did lot of progress on many subjects, but not on MetalLB :(

@rata
Copy link
Member

rata commented Apr 25, 2020

@champtar heh, it happens to all of us. Just wanted to make sure there wasn't a deadlock (you waiting for me, me waiting for you) :)

Old log:
{"caller":"main.go:202","component":"MemberList","msg":"net.go:785: [DEBUG] memberlist: Initiating push/pull sync with: 10.11.12.13:7946","ts":"2020-04-17T00:31:37.51568936Z"}
New log:
{"caller":"net.go:785","component":"MemberList","msg":"[DEBUG] memberlist: Initiating push/pull sync with: 10.11.12.13:7946","ts":"2020-04-17T00:31:37.51568936Z"}

"caller" now references Memberlist code

Signed-off-by: Etienne Champetier <echampetier@anevia.com>
@champtar
Copy link
Contributor Author

champtar commented Apr 27, 2020

@rata done, please review and merge

rata
rata approved these changes Apr 28, 2020
Copy link
Member

@rata rata left a comment

LGTM, thanks!

@rata rata merged commit 734ee67 into metallb:main Apr 28, 2020
@champtar champtar deleted the memberlistlog branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants