Use go-kit log.NewStdlibAdapter instead of our own adapter#587
Conversation
|
@rata this PR was tested ;) |
|
@champtar thanks! I guess the Can you please add in the commit message too how the output looked before this patch too? Other than that, LGTM. But please, if you think it makes sense too, add how the logs looked like before this patch :) |
|
caller is the file/line in the memberlist code yes ( |
|
Don't hesitate to ping me when ready :) |
|
crazy week, I did lot of progress on many subjects, but not on MetalLB :( |
|
@champtar heh, it happens to all of us. Just wanted to make sure there wasn't a deadlock (you waiting for me, me waiting for you) :) |
Old log:
{"caller":"main.go:202","component":"MemberList","msg":"net.go:785: [DEBUG] memberlist: Initiating push/pull sync with: 10.11.12.13:7946","ts":"2020-04-17T00:31:37.51568936Z"}
New log:
{"caller":"net.go:785","component":"MemberList","msg":"[DEBUG] memberlist: Initiating push/pull sync with: 10.11.12.13:7946","ts":"2020-04-17T00:31:37.51568936Z"}
"caller" now references Memberlist code
Signed-off-by: Etienne Champetier <echampetier@anevia.com>
|
@rata done, please review and merge |
2 participants
New log looks like:
{"caller":"net.go:785","component":"MemberList","msg":"[DEBUG] memberlist: Initiating push/pull sync with: 10.11.12.13:7946","ts":"2020-04-17T00:31:37.51568936Z"}