Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifests/metallb.yaml for kubernetes v1.19 #744

Merged
merged 1 commit into from Nov 4, 2020

Conversation

honza801
Copy link
Contributor

According to kubernetes documentation, since v1.19 kubernetes stops using labels with "beta." prefix. Installation manifest manifests/metallb.yaml fixes nodeSelector to kubernetes.io/os.

Fixed #743

According to kubernetes documentation, since v1.19 kubernetes stops using labels with "beta." prefix. Installation manifest manifests/metallb.yaml fixes nodeSelector to kubernetes.io/os.
@honza801 honza801 requested review from daxmc99, johananl and rata as code owners Oct 13, 2020
@russellb
Copy link
Collaborator

lgtm, thanks!

@champtar
Copy link
Contributor

What is the new minimum version of K8S supported ?

@honza801
Copy link
Contributor Author

honza801 commented Oct 14, 2020

see https://v1-15.docs.kubernetes.io/docs/setup/release/notes/

The beta.kubernetes.io/os and beta.kubernetes.io/arch labels, deprecated since v1.14, are targeted for removal in v1.18.

i cannot find the earliest version with kubernetes.io/os support, because older doc than v1.15 does not exist anymore

@champtar
Copy link
Contributor

ok perfect thanks
LGTM

@andersmarkendahl
Copy link

andersmarkendahl commented Oct 16, 2020

@honza801 Previous CHANGELOGs are still tracked in kubernetes git repo and quick search shows the following in file CHANGELOG/CHANGELOG-1.14.md:

- OS and Arch information is now recorded in kubernetes.io/os and kubernetes.io/arch labels on Node objects. The previous labels (beta.kubernetes.io/os and beta.kubernetes.io/arch) are still recorded, but are deprecated and targeted for removal in v1.18.

So I believe this change mean that you need K8s 1.14 or later (actually I believe introduction of new version and deprecation usually go hand in hand)
Thanks for fixing this.

@rata
Copy link
Member

rata commented Oct 16, 2020

@Aoana cool, I wanted to check just that! :). @russellb @champtar thanks for the review, too!

@honza801 thanks a lot for the PR! v0.9.4 was just tagged, but we might need to do a v0.9.5 with this change, maybe?

@johananl johananl added this to the v0.9.5 milestone Oct 16, 2020
@andersmarkendahl
Copy link

@rata A new release might be good, not too far in the future. More people will upgrade to 1.19.x as time passes and it will introduce overhead for metallb community, regarding questions and describing the workaround for this small problem.

@andersmarkendahl
Copy link

@rata this issue was reported again in #768, would it be possible to merge the commit to reduce overhead?
Thanks in advance

@rata
Copy link
Member

rata commented Oct 30, 2020

@Aoana Thanks for the ping. Yes, @johananl will take care of it soon. I'll be away a few days and he will be more active :)

@johananl
Copy link
Member

johananl commented Nov 4, 2020

So if I understand the above correctly, pod scheduling will work as expected on any k8s version starting at v0.14.0 if we merge this? I want to verify we aren't breaking e.g. v0.18.0 by merging this.

@andersmarkendahl
Copy link

So if I understand the above correctly, pod scheduling will work as expected on any k8s version starting at v0.14.0 if we merge this? I want to verify we aren't breaking e.g. v0.18.0 by merging this.

Yes that is correct (I assume you meant 1.X :) ). New field was introduced in .14 and old field removed in .18

@johananl
Copy link
Member

johananl commented Nov 4, 2020

So if I understand the above correctly, pod scheduling will work as expected on any k8s version starting at v0.14.0 if we merge this? I want to verify we aren't breaking e.g. v0.18.0 by merging this.

Yes that is correct (I assume you meant 1.X :) ). New field was introduced in .14 and old field removed in .18

Bah, I've been working on too many alpha projects 🙈 Thanks @Aoana.

Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johananl johananl merged commit a408d93 into metallb:main Nov 4, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot install metallb on kubernetes v1.19.x via manifest
6 participants