Update manifests/metallb.yaml for kubernetes v1.19

[honza801]

According to kubernetes documentation, since v1.19 kubernetes stops using labels with "beta." prefix. Installation manifest manifests/metallb.yaml fixes nodeSelector to kubernetes.io/os.

Fixed #743

[russellb]

lgtm, thanks!

[champtar]

What is the new minimum version of K8S supported ?

[honza801]

see https://v1-15.docs.kubernetes.io/docs/setup/release/notes/

The beta.kubernetes.io/os and beta.kubernetes.io/arch labels, deprecated since v1.14, are targeted for removal in v1.18.

i cannot find the earliest version with kubernetes.io/os support, because older doc than v1.15 does not exist anymore

[champtar]

ok perfect thanks
LGTM

[andersmarkendahl]

@honza801 Previous CHANGELOGs are still tracked in kubernetes git repo and quick search shows the following in file CHANGELOG/CHANGELOG-1.14.md:

- OS and Arch information is now recorded in kubernetes.io/os and kubernetes.io/arch labels on Node objects. The previous labels (beta.kubernetes.io/os and beta.kubernetes.io/arch) are still recorded, but are deprecated and targeted for removal in v1.18.

So I believe this change mean that you need K8s 1.14 or later (actually I believe introduction of new version and deprecation usually go hand in hand)
Thanks for fixing this.

[rata]

@Aoana cool, I wanted to check just that! :). @russellb @champtar thanks for the review, too!

@honza801 thanks a lot for the PR! v0.9.4 was just tagged, but we might need to do a v0.9.5 with this change, maybe?

[andersmarkendahl]

@rata A new release might be good, not too far in the future. More people will upgrade to 1.19.x as time passes and it will introduce overhead for metallb community, regarding questions and describing the workaround for this small problem.

[andersmarkendahl]

@rata this issue was reported again in #768, would it be possible to merge the commit to reduce overhead?
Thanks in advance

[rata]

@Aoana Thanks for the ping. Yes, @johananl will take care of it soon. I'll be away a few days and he will be more active :)

[johananl]

So if I understand the above correctly, pod scheduling will work as expected on any k8s version starting at v0.14.0 if we merge this? I want to verify we aren't breaking e.g. v0.18.0 by merging this.

[andersmarkendahl]

So if I understand the above correctly, pod scheduling will work as expected on any k8s version starting at v0.14.0 if we merge this? I want to verify we aren't breaking e.g. v0.18.0 by merging this.

Yes that is correct (I assume you meant 1.X :) ). New field was introduced in .14 and old field removed in .18

[johananl]

So if I understand the above correctly, pod scheduling will work as expected on any k8s version starting at v0.14.0 if we merge this? I want to verify we aren't breaking e.g. v0.18.0 by merging this.

Yes that is correct (I assume you meant 1.X :) ). New field was introduced in .14 and old field removed in .18

Bah, I've been working on too many alpha projects 🙈 Thanks @Aoana.

[johananl]

LGTM