-
Notifications
You must be signed in to change notification settings - Fork 1k
chart: new additionalLabels for podMonitors and PrometheusRules #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yves Mettier <ymettier@free.fr>
|
@gclawes FYI |
|
On the subject of |
|
I guess you will do it faster and better than I. @gclawes thanks in advance if you can do it : feel free to add a commit ! |
Signed-off-by: Graeme Lawes <graemelawes@gmail.com>
…y release process Signed-off-by: Graeme Lawes <graemelawes@gmail.com>
|
@russellb I've pushed the relevant changes to Edit: commits here: https://github.com/ymettier/metallb/compare/additionalLabels...gclawes:additionalLabels |
|
@gclawes i pushed your commits to this PR |
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| # NOTE: this value is updated by the metallb release process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gclawes . This is a nit for the future, but maybe we should change "0.9.6" to something else, like "0.0.0" ... I just thought of this, but now this version in main is behind what's in the v0.10 branch, since that automation just updates the release branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense.
|
Thanks, everyone. I'm going to wait for tests to all pass, but I'd also like to add something to the release notes. I'll handle the release notes part. |
Add a release note for the addition in PR #886.
Add a release note for the addition in PR metallb#886.
Signed-off-by: Yves Mettier ymettier@free.fr
This PR allows to specify additionnal labels on podMonitors and PrometheusRules.
This is needed when you are using Prometheus-Operator and when you configured it to use specific podMonitors and specific PrometheusRules using a specific label.
Important note : I have not bumped the chart version in Chart.yaml (because I don't know when you may merge this PR).