Make BGP source address configurable #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johananl
force-pushed
the
johananl/bgp-src-addr
branch
from
c037d07 to
91c390d
Compare
johananl
force-pushed
the
johananl/bgp-src-addr
branch
from
940d341 to
d4c9aaa
Compare
johananl
force-pushed
the
johananl/bgp-src-addr
branch
2 times, most recently
from
d1b233a to
14801e7
Compare
johananl
force-pushed
the
johananl/bgp-src-addr
branch
3 times, most recently
from
58f225c to
86a9742
Compare
rata
approved these changes
Jul 6, 2021
Contributor
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks! I've left two small comments (one is just a question), I don't think I need to review again even if you do one small change I asked in the comment (remove one sentence from docs).
I like the change to net.IP for the srcAddr param :)
johananl
force-pushed
the
johananl/bgp-src-addr
branch
from
86a9742 to
8ccb048
Compare
johananl
force-pushed
the
johananl/bgp-src-addr
branch
from
8ccb048 to
afe878e
Compare
|
Can you make a release containing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for #672.
TODO:
Add testsFixes #670.