Skip to content

Design proposal: Expand BGP with BFD capabilities#927

Merged
rata merged 1 commit intometallb:mainfrom
fedepaol:frrproposal
Oct 13, 2021
Merged

Design proposal: Expand BGP with BFD capabilities#927
rata merged 1 commit intometallb:mainfrom
fedepaol:frrproposal

Conversation

@fedepaol
Copy link
Member

Extending BGP with BFD will make the sessions more reliable and it will make the detection of a neighbour failure faster, allowing users to provide a better service. Here, we submit a design proposal to support that case.

@fedepaol
Copy link
Member Author

cc @markdgray @russellb

Copy link
Contributor

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedepaol Sorry for the late review. It mostly LGTM, just left some questions to clarify some things

@fedepaol fedepaol mentioned this pull request Sep 17, 2021
@fedepaol fedepaol force-pushed the frrproposal branch 2 times, most recently from 96b1989 to df5063b Compare September 23, 2021 12:24
@fedepaol fedepaol mentioned this pull request Sep 28, 2021
Copy link
Contributor

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this - lgtm. I left some comments, but none of them are blocking.

@rata you had said "mostly lgtm" before, so let me know if you wanted to review again before we merge this one

Extending BGP with BFD will make the sessions more reliable and it will
make the detection of a neighbour failure faster, allowing users to
provide a better service. Here, we submit a design proposal to support
that.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
@fedepaol
Copy link
Member Author

@russellb @rata I think I addressed all the comments here.

@cgoncalves
Copy link
Contributor

LGTM

Copy link
Contributor

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rata rata merged commit 712a685 into metallb:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants