Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my three published plugins #61

Merged
merged 2 commits into from Nov 1, 2014
Merged

Add my three published plugins #61

merged 2 commits into from Nov 1, 2014

Conversation

@majodev
Copy link
Contributor

@majodev majodev commented Oct 24, 2014

metalsmith-datamarkdown - Use markdown content within html tags via data-markdown attribute
metalsmith-wordcount - Compute wordcount / average reading time
metalsmith-headingsidentifier - Add an id and anchor to all headings on a page. Ideal for permalinks.

BTW my first pull request ever! :)

metalsmith-datamarkdown - Use markdown content within html tags via data-markdown attribute
metalsmith-wordcount - Compute wordcount / average reading time
metalsmith-headingsidentifier - Add an id and anchor to all headings on a page. Ideal for permalinks.
@majodev majodev changed the title Add my three publish plugins Add my three published plugins Oct 24, 2014
@ianstormtaylor
Copy link
Contributor

@ianstormtaylor ianstormtaylor commented Oct 24, 2014

badass! sweet looking plugins too :)

@ianstormtaylor
Copy link
Contributor

@ianstormtaylor ianstormtaylor commented Oct 24, 2014

one suggestion would be to add dashes and spaces in the plugin names, to make them more readable and consistent, like:

{
  "name": "Data Markdown",
  "icon": "gridlines",
  "repository": "https://github.com/majodev/metalsmith-data-markdown",
  "description": "Use markdown content within html tags via data-markdown attribute."
}

@majodev
Copy link
Contributor Author

@majodev majodev commented Oct 25, 2014

Thanks for your feedback!
I also linked these plugins with my blog post, used them within my own project and published them on npm. So please give me some time to make these modifications...

Renamed packages as suggested by @ianstormtaylor. (Also removed and republished them on npm).
@majodev
Copy link
Contributor Author

@majodev majodev commented Oct 28, 2014

Renamed as suggested!

@majodev
Copy link
Contributor Author

@majodev majodev commented Oct 29, 2014

In the case you were unsure about the stability of the plugins: All 3 plugins now include tests and should work as intended...

@ianstormtaylor
Copy link
Contributor

@ianstormtaylor ianstormtaylor commented Nov 1, 2014

Awesome! Thanks so much for taking the effort to rename them!

ianstormtaylor added a commit that referenced this issue Nov 1, 2014
Add my three published plugins
@ianstormtaylor ianstormtaylor merged commit d7a24f1 into metalsmith:master Nov 1, 2014
@majodev majodev deleted the patch-1 branch Nov 17, 2014
@Ajedi32 Ajedi32 added the plugins label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants