Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pattern matching #1

Merged
merged 2 commits into from
Mar 11, 2014
Merged

Fix pattern matching #1

merged 2 commits into from
Mar 11, 2014

Conversation

stevenschobert
Copy link
Contributor

Fixed an issue that was causing all files to get ignored, regardless of the pattern.

Multimatch was returning an empty array when the pattern did not match the filename, and this was passing as truthy in the test, so the files were always removed. I updated it to check the length of the array instead.

for (var file in files) {
  if (match(file, patterns).length > 0) delete files[file];
}

This issue was also slipping past the test suite, since all of the fixture's build/ directories were under version control. When the test suite would run, the builds would fail, but the test suite would use the previous run's output so the tests were still passing.

I updated the tests to clear out the build directories for each run and ignore them for the future. I added a couple dependencies for the test suite, but I'll be happy to take those out if you'd rather not have them :)

Also, I've been loving Metalsmith so far! 😁

@ianstormtaylor
Copy link
Contributor

wow not exactly the least important bug to fix :) sorry for that blatant incompetence. thanks for the fixes!

ianstormtaylor added a commit that referenced this pull request Mar 11, 2014
@ianstormtaylor ianstormtaylor merged commit 27b7df3 into metalsmith:master Mar 11, 2014
@stevenschobert
Copy link
Contributor Author

@ianstormtaylor Oh no worries at all, just happy to help! That doesn't even come close to the amount of bugs I've written. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants