Fix pattern matching#1
Merged
ianstormtaylor merged 2 commits intoMar 11, 2014
Merged
Conversation
Contributor
|
wow not exactly the least important bug to fix :) sorry for that blatant incompetence. thanks for the fixes! |
Contributor
Author
|
@ianstormtaylor Oh no worries at all, just happy to help! That doesn't even come close to the amount of bugs I've written. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue that was causing all files to get ignored, regardless of the pattern.
Multimatch was returning an empty array when the pattern did not match the filename, and this was passing as truthy in the test, so the files were always removed. I updated it to check the length of the array instead.
This issue was also slipping past the test suite, since all of the fixture's
build/directories were under version control. When the test suite would run, the builds would fail, but the test suite would use the previous run's output so the tests were still passing.I updated the tests to clear out the build directories for each run and ignore them for the future. I added a couple dependencies for the test suite, but I'll be happy to take those out if you'd rather not have them :)
Also, I've been loving Metalsmith so far! 😁