New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI: proofs of some unproven assertions of set.mm. #1710
Conversation
|
The Travis failures were: ?Warning: Line number 110099 ends with a space character, which is discouraged. This check was added recently to prevent frustrating diffs (I know we can use -Z but not all scripts do that). The fix should be easy. ?Warning: Line number 374567 has 81 characters (should have 79 or less): When this occurs in proofs, it can be solved with the command 'save proof */compressed/fast' in metamath.exe. ?Warning: There is no "(Contributed by...)" in the comment above statement If the contributor is OpenAI, this can be solved by adding "(Contributed by OpenAI, 7-Jul-2020.)" to the comment (usually at the end, but anywhere in the comment will do). |
Thank you very much! I just corrected those mistakes, hoping I didn't leave any out. |
|
I think this PR must be reviewed very carefully, and a revision is absolutely necessary. Most of the theorems have no comments, and their meaning is not clear. As long as the theorems are in mathboxes, this does not matter (the owner can revise/remove them), but for the main body we must be restrictive, assuring quality. |
|
@avekens I see what you mean. In some cases a comment appears in @( @) brackets which is, I believe, not notation from the metamath book but intended for humans who are trying to nest comments inside of commented-out blocks. I am however grateful for the proof of rntrclfv and look forward to seeing the eventual paper with the methods. |
|
@avekens \o/ (working on it) |
|
Review
From the context it looks like
Similar comments apply to
|
Thank you very much for this review! |
|
Here my remarks on the (remaining) theorems. In summary, I think only the two theorem of BJ's and RP's mathboxes should be kept (if the owners of these mathboxes agree).
|
|
Hi Auguste, fltsval1 shouldn't be in my mathbox (I'm pretty sure I've never had unproven theorems in my mathbox). In my local set.mm version (it's not up to date) fltsval1 is in a section for the Fermat's Last Theorem Glauco |
|
I've only had time to look at ~bj-inrab3 and it looks good to me. Congratulations to @spolu and @augustepoiroux . |
|
I have added an empty mathbox for OpenAI in PR #1712 (search for "Mathbox for OpenAI" in set.mm). You should be able to merge it with this PR without conflict. Normally, contributions by OpenAI other than proof shortenings should initially go into a mathbox specifically for OpenAI instead of being edited directly into the main part of set.mm. There is more freedom in terms of what you can do in your mathbox, as opposed to the main part of set.mm which is vetted carefully for certain conventions to maintain quality. Over time we may decide to move useful theorems from the OpenAI mathbox to the main part of set.mm. By the way the conventions we follow are described here: Comments on the specific changes in this PR: axpowndNEWlem1 - this does not seem to shorten the original proof, and worse it makes the theorem no longer useful by introducing a $d. I think it should be deleted (or at least moved to the OpenAI mathbox if you want to keep it). fltsval1 - as has been mentioned, this theorem was commented out and wasn't intended to be used. The whole commented-out section called "Fermat's last theorem" should have been deleted a long time ago but was overlooked, and I think now is the time to delete it to prevent further confusion. (I am puzzled as to why this was chosen by OpenAI since it is just a comment; I assume OpenAI recognizes the comment syntax? If it was chosen manually, maybe syntax highlighting in the editor would prevent accidentally using a commented-out theorem.) The proof can be moved to the OpenAI mathbox if you want to keep it, but I will delete that whole section in the next few days. lt2sqtROY, sqrltROY, - same issue: this is in a commented-out section that hasn't been maintained since 2005, and it should have been deleted a long time ago since it will never be used. Again I will delete that section in the next few days, so if you want to keep the proofs they should be moved to the OpenAI mathbox. gsummptadd - This was commented out in TA's mathbox and appears to be superceded by gsummptfidmadd, so might become deleted (TA can decide that). Keep in mind that work inside of other people's mathboxes is often work in progress, and it is generally advisable to coordinate any work there with the mathbox owner. bj-inrab3, rntrclfv - Again, these were commented out theorems in others' mathboxes; the mathbox owners can decide the disposition. |
OpenAI's mathbox
412fc39
to
09286f4
Compare
|
To go back to why we proposed these proofs: |
|
I'm coming after the battle... I probably needed ~ gsummptadd in one of my work in progress at some point in time (March '18 it seems), but found a better solution later on which did not require it anymore, and kept the theorem statement in comments as it was still a valid useful statement which would need to be proven sooner or later. Then came Alexander who proved it and named it differently, ~ gsummptfidmadd. I'll delete the commented out statement. How about ~ gsummptres , which is in the comment right afterwards, did OpenAI manage to find a proof? |
As suggested by @david-a-wheeler , we (OpenAI @spolu ) ran our model on some of the unproven statement in set.mm. This PR proposes a few proofs we found:
The model also detected that some are already proven under another name