Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating javaclient.yml with rabbitmq configs #38

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
3 participants
@n3w
Copy link
Contributor

commented May 7, 2018

No description provided.

@metas-ts

This comment has been minimized.

Copy link
Member

commented May 8, 2018

Hi @n3w thanks a lot for the PR!
I asked @metas-jb to take a look. If he doesn'T get to it, I'm going to check it out myself later this week (or maybe on the weekend)

(Related to metasfresh/metasfresh#3772)

@metas-ts metas-ts requested a review from metas-jb May 8, 2018

@metas-jb
Copy link
Member

left a comment

Tests of these changes worked fine:

  • the metasfresh-docker stack started up properly
  • services connected to rabbitmq
  • ports for connecting the java client exposed properly
    👍

@metas-ts metas-ts merged commit ffb5e7d into metasfresh:master May 8, 2018

@n3w

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2018

thanks for merging it in so fast!

@metas-ts

This comment has been minimized.

Copy link
Member

commented May 8, 2018

thx for your contribution :-) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.