Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new pricelist version using a pricelist schema #279

Closed
metas-dh opened this issue Aug 5, 2019 · 0 comments

Comments

@metas-dh
Copy link
Member

commented Aug 5, 2019

Test shall include:

  • Customer Fixtures to use: (if needed)
  • What to test
  • Expectation for the test to be successful

Create a new pricelist version using a pricelist schema and a base pricelist.

This needs a pricelist schema, created in #278.

https://recordit.co/fLDqIMvNuT

Note:

  1. A new pricelist version can be created by using a pricelist schema and a base pricelist.
  2. We already have an old SQL test for creating product prices on a base pricelist, a pricelist schema, creating a new PLV using those and checking the newly created prices: http://dewiki908/mediawiki/index.php/Test_Method:_SQL-Based
    => the video shows only 1 single price being created which is not realistic at all, but creating a realistic amt of test data will take a lot of time, which is why the SQL based test was created in the first place.

In the product window, a new price is added as well after creating a new pricelist version, stopped the video too early:

2019-08-05 21_19_12-NotificationsForm

Todo for developer (besides coding)

  • Always make sure the issue is in the correct project lane
  • [ ] run your test in jenkins e2e on a vanilla db
  • [ ] jenkins console URL / cypress dashboard URL to the successful test suite run (not just yours)
  • [ ] get it integrated into master
    • [ ] (pull request URL)
  • This was already implemented in #278.

All Flags are ticked? Congratulations, you have delivered!

@metas-dh metas-dh added this to To do in e2e via automation Aug 5, 2019

@metas-dh metas-dh moved this from To do to Data Prepared in e2e Aug 5, 2019

@TheBestPessimist TheBestPessimist moved this from Data Prepared to In progress in e2e Aug 7, 2019

@metas-dh metas-dh referenced this issue Aug 7, 2019
4 of 4 tasks complete

@TheBestPessimist TheBestPessimist moved this from In progress to To be reviewed in e2e Aug 7, 2019

TheBestPessimist added a commit that referenced this issue Aug 7, 2019

e2e automation moved this from To be reviewed to Done Aug 7, 2019

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 9, 2019
Update ReleaseNotes.md
  * [#116](metasfresh/metasfresh-e2e#116) Create new tour and transportation order
  * [#136](metasfresh/metasfresh-e2e#136) Change product price (product window) and use it
  * [#153](metasfresh/metasfresh-e2e#153) Change warehouse in material receipt candidate
  * [#229](metasfresh/metasfresh-e2e#229) Create new Shipper
  * [#231](metasfresh/metasfresh-e2e#231) Adapt Tourversion
  * [#248](metasfresh/metasfresh-e2e#248) Create Disposal from Handling Unit Editor
  * [#277](metasfresh/metasfresh-e2e#277) Create Vendor Return
  * [#278](metasfresh/metasfresh-e2e#278) Create pricelist schema
  * [#279](metasfresh/metasfresh-e2e#279) Create new pricelist version using a pricelist schema
  * [#280](metasfresh/metasfresh-e2e#280) Add a product to a pricelist schema and create a new PLV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.