Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev fix tests 2 #259

Merged
merged 7 commits into from Aug 5, 2019

Conversation

@TheBestPessimist
Copy link
Member

commented Aug 2, 2019

No description provided.

TheBestPessimist added some commits Aug 1, 2019

Reverse adding field `simpleListField`to `cy.selectInListField` and i…
…nstead use `cy.writeIntoLookupListField(, , , typeList=true)`
Add click force to `cy.selectInListField` as on ungodly occasions, cy…
…press just moves the element out of view and click doesnt work. dunno why
Add message that `cy.writeIntoLookupListField` is really fiddly with …
…combo fields like bpartner address and **should not be used there**.
if (theCheckboxValue) {
cy.clickOnCheckBox(fieldName, expectedPatchValue, modal, rewriteUrl, skipRequest);
} else {
// Nothing to do, already unchecked

This comment has been minimized.

Copy link
@siemiatj

siemiatj Aug 2, 2019

Contributor

Theeen I guess we don't need that.

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 2, 2019

Author Member

I though leaving the comment there could help for future readability. do you think i should just take it out?

@TheBestPessimist TheBestPessimist merged commit 7b64fd9 into master Aug 5, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@TheBestPessimist TheBestPessimist deleted the dev-fix-tests-2 branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.