Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress overscroll bug workarond #275

Merged
merged 6 commits into from Aug 6, 2019

Conversation

@TheBestPessimist
Copy link
Member

commented Aug 5, 2019

On tall pages it seems cypress overscrolls elements out of view: https://dashboard.cypress.io/#/projects/5yp4q1/runs/435/failures/86abb138-9e1d-4fe9-9a1f-d16e6fec73f0 (check video)

There's are multiple bugs for this, and also a workaround: cypress-io/cypress#871 (comment)

Can we add this workaround for all the tests?

It seems that the workaround works as the failed tests from above are green now: https://dashboard.cypress.io/#/projects/5yp4q1/runs/436/specs

@TheBestPessimist TheBestPessimist requested a review from siemiatj Aug 5, 2019

@metas-ts metas-ts merged commit f62ded7 into master Aug 6, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@metas-ts metas-ts deleted the test-cypress-overscroll-wrokarond branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.