Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#131 Change text dunning document #294

Merged
merged 6 commits into from Aug 12, 2019

Conversation

@cristinastefan90
Copy link
Contributor

commented Aug 9, 2019

#131
#131 Change text dunning document
@metas-dh metas-dh referenced this pull request Aug 9, 2019
4 of 4 tasks complete

cristinastefan90 added some commits Aug 9, 2019

#131 openReferencedDocuments solution
#131 Change text dunning document
#131 refactoring
#131 Change text dunning document
.setCustomer(true)
.setDunning(dunningTypeName)
.setPaymentTerm(paymentTerm)
.setBank(undefined);

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 9, 2019

Member

Typo here with undefined ?

This comment has been minimized.

Copy link
@cristinastefan90

cristinastefan90 Aug 9, 2019

Author Contributor

removed.

cy.completeDocument();
});
it('Sales Invoice is not paid', function() {
cy.getCheckboxValue('IsPaid').then(checkBoxValue => {

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 9, 2019

Member

There's also a cypress function: cy.expectCheckboxValue('name', expectedValue) which can be used here. (just fyi)

This comment has been minimized.

Copy link
@cristinastefan90

cristinastefan90 Aug 9, 2019

Author Contributor

done.

cy.executeHeaderActionWithDialog('C_Dunning_Candidate_Create');
cy.setCheckBoxValue('IsFullUpdate', true, true);
cy.pressStartButton();
// cy.wait(8000);

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 9, 2019

Member

cleanup: pls remove comment

This comment has been minimized.

Copy link
@cristinastefan90

cristinastefan90 Aug 9, 2019

Author Contributor

done

it('Ensure there are exactly 2 Dunning Candidates - one for each dunning type level', function() {
DunningCandidates.visit();
filterBySalesInvoiceDocNumber(siDocumentNumber);
DunningCandidates.getRows().should('have.length', 2);

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 9, 2019

Member

alternative: cy.expectNumberOfRows(2) (just fyi)

This comment has been minimized.

Copy link
@cristinastefan90

cristinastefan90 Aug 9, 2019

Author Contributor

you're right, done.

@@ -1,3 +1,5 @@
import { RewriteURL } from "../utils/constants";

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 9, 2019

Member

pls eslint this file. the imports should use ' and not "

This comment has been minimized.

Copy link
@cristinastefan90

cristinastefan90 Aug 9, 2019

Author Contributor

done

cristinastefan90 added some commits Aug 9, 2019

#131 changes after cr
#131 Change text dunning document
#131 changes after cr
#131 Change text dunning document

@TheBestPessimist TheBestPessimist merged commit 0b07347 into master Aug 12, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@TheBestPessimist TheBestPessimist deleted the gh131-app branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.