Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft 2: Use a minimal fixture for customer-specific data only #295

Merged
merged 4 commits into from Aug 19, 2019

Conversation

@TheBestPessimist
Copy link
Member

commented Aug 9, 2019

Here's a new approach to the 1 fixture to rule them all. This idea popped out after talking with @DH.

In our fixture we don't set the WHOLE OBJECT (and all the objects), but only the things that the customer wants to have changed and we use the existing fixtures and builders for everything else.

It is my understanding that the customer mostly wants familiar names (product, bpartner, pricelist, prod.category, etc.) and quantities, and the rest of the data should "mostly" be all right.

In this way the customer fixture is much smaller, without duplicated data (because I expect most stuff to be 80% the same between tests), and we'll also be able to use our builders and everything else just like we are doing now.

#286

TheBestPessimist added some commits Aug 9, 2019

Create draft where the fixture only contains the values that the test…
… would have already changed.

Look low little change we had to do :^).
I like this draft waaaay better than the **FULL FIXTURE** alternative.

#286
@metas-dh metas-dh referenced this pull request Aug 9, 2019
3 of 4 tasks complete

@TheBestPessimist TheBestPessimist changed the title Use a minimal fixture for customer-specific data only Draft 2: Use a minimal fixture for customer-specific data only Aug 12, 2019

it('reaaaaaalyyyyyyyyy', function() {
cy.wait(5000);
});

This comment has been minimized.

Copy link
@cristinastefan90

cristinastefan90 Aug 19, 2019

Contributor

This looks a bit ugly:( do we reaaaalyyy need the wait in here?

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 19, 2019

Author Member

Unfortunately, sometimes (eg. 2/5 maybe) we get that problem with getLanguageSpecific, so this wait is needed right now -- at least on my machine :(

This comment has been minimized.

Copy link
@cristinastefan90

@cristinastefan90 cristinastefan90 merged commit d610142 into master Aug 19, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@TheBestPessimist TheBestPessimist deleted the gh286-minimal-fixture branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.