Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#309 Materialentnahme partial #322

Merged
merged 22 commits into from Aug 23, 2019

Conversation

@cristinastefan90
Copy link
Member

commented Aug 19, 2019

#309 partial impl
#309 Materialentnahme partial
@metas-dh metas-dh referenced this pull request Aug 19, 2019
5 of 5 tasks complete
#309 partial impl
#309 Materialentnahme partial
#309 last refinements
#309 Materialentnahme partial
#309 executeQuickActions sol
#309 Materialentnahme partial
#309 executeQuickAction story continues
#309 Materialentnahme partial
#309 changes to executeQucikActions call
#309 Materialentnahme partial
#309 added param
 #309 Materialentnahme partial
#309 refactored
#309 Materialentnahme partial
#309 partial sol
#309 Materialentnahme partial
#309 some checks
#309 Materialentnahme partial
#309 more checks
#309 Materialentnahme partial
#309 sol
#309 Materialentnahme partial
#309 reading prerequisites from fixture
#309 Materialentnahme partial
#309 read test data from fixture
#309 Materialentnahme partial
#309 small changes
#309 Materialentnahme partial
#309 changes after cr and some tests fixes
#309 Materialentnahme partial
.setPackingMaterial(packingMaterialForTU)
.apply();
});
/**For some reasons,the quantity for the packgut cannot be added in advanced edit mode, only like below */

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Aug 22, 2019

Member

You're creating a new Packing Instructions Version via the normal builder.
But afterwards you are editing the qty in the M_HU_PI_Item tab. This qty edit part should be part of the builder js object (and set in the normal apply() method in the builder.

Basically you extract this part to that builder instead of keeping in this test, and maybe also copying it to other tests which may need to set the qty to a certain value.

#309 changes after cr
#309 Materialentnahme partial

@TheBestPessimist TheBestPessimist merged commit 2faf51c into master Aug 23, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@TheBestPessimist TheBestPessimist deleted the gh309-app branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.