Skip to content

Commit

Permalink
#5639 Use service instead of repo
Browse files Browse the repository at this point in the history
#5639 Print Picklist from Picking terminal v2
metasfresh/metasfresh#5639
  • Loading branch information
cristinamghita committed Oct 11, 2019
1 parent 2a31bad commit e47a391
Showing 1 changed file with 5 additions and 5 deletions.
Expand Up @@ -9,7 +9,7 @@

import de.metas.adempiere.report.jasper.OutputType;
import de.metas.handlingunits.picking.PickingCandidate;
import de.metas.handlingunits.picking.PickingCandidateRepository;
import de.metas.handlingunits.picking.PickingCandidateService;
import de.metas.handlingunits.picking.PickingCandidateStatus;
import de.metas.inoutcandidate.model.I_M_Packageable_V;
import de.metas.process.AdProcessId;
Expand Down Expand Up @@ -55,7 +55,7 @@ public class PackageablesView_PrintPicklist extends PackageablesViewBasedProcess
private ProductsToPickRowsRepository productsToPickRowsRepository;

@Autowired
private PickingCandidateRepository pickingCandidateRepository;
private PickingCandidateService pickingCandidateService;

final private IADPInstanceDAO adPInstanceDAO = Services.get(IADPInstanceDAO.class);

Expand All @@ -70,15 +70,15 @@ private ProcessPreconditionsResolution acceptIfPickingCandidatesAreDraft()
{
final PackageableRow row = getSingleSelectedRow();

// allow draft pikcing candidates
final List<PickingCandidate> pickingCandidates = pickingCandidateRepository.getByShipmentScheduleIdsAndStatus(row.getShipmentScheduleIds(), PickingCandidateStatus.Draft);
// allow draft picking candidates
final List<PickingCandidate> pickingCandidates = pickingCandidateService.getByShipmentScheduleIdsAndStatus(row.getShipmentScheduleIds(), PickingCandidateStatus.Draft);
if (pickingCandidates.size() > 0)
{
return ProcessPreconditionsResolution.accept();
}

// allow if there is no picking candidate yet, this process will generate before printing
final boolean existsPickingCandidates = pickingCandidateRepository.existsPickingCandidates(row.getShipmentScheduleIds());
final boolean existsPickingCandidates = pickingCandidateService.existsPickingCandidates(row.getShipmentScheduleIds());
if (!existsPickingCandidates)
{
return ProcessPreconditionsResolution.accept();
Expand Down

0 comments on commit e47a391

Please sign in to comment.