New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch shall use slf4j instead of log4j #757

Closed
teosarca opened this Issue Dec 18, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@teosarca
Member

teosarca commented Dec 18, 2017

What is the current behavior?

elasticsearch is using log4j. As an effect the console is full of exceptions in case there is no elasticsearch server to connect too.

This issue was introduced by metasfresh/metasfresh#2646 where the webui pom's was modified and somehow, indirectly, we have the log4j as dependency.
Elasticsearch 2.4.4 prefers log4j instead of slf4j so it picks that first. See:

https://github.com/elastic/elasticsearch/blob/fcbb46dfd45562a9cf00c604b30849a6dec6b017/core/src/main/java/org/elasticsearch/common/logging/ESLoggerFactory.java#L33-L48

Which are the steps to reproduce?

Start webui server without elasticsearch server.

What is the expected or desired behavior?

elasticsearch shall use slf4j. In slf4j we already configured to use INFO level when logging those connection issues.

# NOTE: Avoid spamming the console in case there is no connection to elasticsearch. Those "Connection refused" are logged as INFO
logging.level.org.elasticsearch.client.transport=WARN

Note to IT

nothing to test

@teosarca teosarca added the type:bug label Dec 18, 2017

@teosarca teosarca self-assigned this Dec 18, 2017

@metas-lc metas-lc closed this Dec 19, 2017

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jan 5, 2018

update releaseNotes
[#768](metasfresh/metasfresh-webui-api#768)
Picking Tray Clearing: packing HUs: generate shipper's package label
[#3281](#3281)
C_Tax.ValidFrom bug
[#3272](#3272) Provide
Periods for 2018
[#741](metasfresh/metasfresh-webui-api#741)
WebUI window C_Printing_Queue broken
[#769](metasfresh/metasfresh-webui-api#769)
New context variable for isWebUI
[#764](metasfresh/metasfresh-webui-api#764)
Receipt candidates: HU editor: cannot call Transform for a CU
[#3237](#3237) New
Document "Source of Supply"
[#1465](metasfresh/metasfresh-webui-frontend#1465)
frontend: Processes: when calling a process frontend shall provide which
are the selected rows in the left/right view
[#3230](#3230) Pharma:
import prices
[#763](metasfresh/metasfresh-webui-api#763)
Picking Tray Clearing: packing HUs: Add to Transportation Order, Ship
and Invoice action
[#2822](#2822) Empty
Country in Price List not working
[#3238](#3238) Create
Missing M_Cost records on the fly
[#1752](#1752) System
Element overwrite on Window Field
[#3233](#3233) WebUI:
Role permission constraints missing in Subtabs
[#757](metasfresh/metasfresh-webui-api#757)
elasticsearch shall use slf4j instead of log4j
[#752](metasfresh/metasfresh-webui-api#752)
Picking Tray Clearing: picking slot filter no results
[#3227](#3227) Attachment
related perf problem in swing client
[#3155](#3155) Create
special pharma import product table
[#3225](#3225) Error on
unclosing a "manually" created PPOrder
[#3222](#3222) refactor
trx event listeners
[#758](metasfresh/metasfresh-webui-api#758)
Picking Tray Clearing: process to take out an HU and add it to existing
HU
[#760](metasfresh/metasfresh-webui-api#760)
Picking Tray Clearing: process to take out an HU and add it to new HU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment