New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking Tray Clearing: packing HUs: Add to Transportation Order, Ship and Invoice action #763

Closed
teosarca opened this Issue Dec 19, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@teosarca
Member

teosarca commented Dec 19, 2017

Is this a bug or feature request?

part of metasfresh/metasfresh#3190

similar with #751

What is the expected or desired behavior?

  • open Picking Tray Clearing
  • select a picking slot
  • make sure you have some HUs in the right side view
  • select one or more and call the new "Add to Transportation Order, Ship and Invoice" action
    the action opens and user is able to select an open Transportation Order
    When the process is executed, it shall
  • create M_Package(s), M_Package_HU(s) and link them to given Transportation Order
  • the HUs added to the transportation order shall no longer be visible in the right side view, nor later.
  • creates a shipment for those HUs (shipment schedules are updated correctly)
  • creates an invoice for
    ** all invoice candidates which are "linked" to those shipment schedules of those HUs
    ** invoice candidates which have a Invoice Schedule set are skipped. They will be invoiced on that schedule (e.g. monthly, weekly etc)

User shall get a notification when:

  • the shipment is generated
  • the invoice is generated (if any)
  • something went wrong (e.g. invoice generate workpackage(s) failed)

Note to IT

  • regression make sure generating shipments from HUs still works in Swing
  • regression on generating Invoices
  • re-test metasfresh/metasfresh#1905, see below
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 19, 2017

Member

update: partial developed

Member

teosarca commented Dec 19, 2017

update: partial developed

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 19, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 19, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 19, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 19, 2017

GenerateInOutFromHU improvements
* complete shipments param
* InvoiceMode param

metasfresh/metasfresh-webui-api#763

teosarca added a commit that referenced this issue Dec 19, 2017

teosarca added a commit that referenced this issue Dec 19, 2017

teosarca added a commit that referenced this issue Dec 19, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 20, 2017

GenerateInOutFromHU.isAllowRetryOnError shall return false
there is no point to allow retrying because a regular user cannot do
that

metasfresh/metasfresh-webui-api#763

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 21, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 21, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 21, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 21, 2017

HUShipperTransportationBL: lock the HUs after trx commit
else, it might happen that the trx fails but the HU remains locked

metasfresh/metasfresh-webui-api#763

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 21, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 21, 2017

teosarca added a commit to metasfresh/metasfresh that referenced this issue Dec 21, 2017

teosarca added a commit that referenced this issue Dec 21, 2017

WEBUI_PackingHUsView_AddHUsToShipperTransportationShipAndInvoice: don…
…'t run async

because if we would run async we have no possiblity to vanish the HU and
put it back in case of failure

#763
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 21, 2017

Member

Hotfixed error when generating the receipt in Swing.
As as side effect, metasfresh/metasfresh#1905 shall be retested because on Swing the code introduced there was not executed, because the receipts were not collected.

The error stacktrace was:

Caused by: org.adempiere.exceptions.AdempiereException: Cannot provide the generated shipments because the result was not configured to retain them
    at de.metas.inoutcandidate.api.impl.DefaultInOutGenerateResult.getInOuts(DefaultInOutGenerateResult.java:87)
    at de.metas.handlingunits.receiptschedule.impl.HUReceiptScheduleBL.processReceiptSchedules0(HUReceiptScheduleBL.java:384)
    at de.metas.handlingunits.receiptschedule.impl.HUReceiptScheduleBL.lambda$0(HUReceiptScheduleBL.java:290)
    at org.adempiere.ad.trx.api.impl.TrxCallableWrappers$5.call(TrxCallableWrappers.java:222)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call0(AbstractTrxManager.java:771)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:683)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:584)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:515)
    at de.metas.handlingunits.receiptschedule.impl.HUReceiptScheduleBL.processReceiptSchedules(HUReceiptScheduleBL.java:290)
    at de.metas.handlingunits.client.terminal.select.api.impl.ReceiptScheduleFiltering.processRows(ReceiptScheduleFiltering.java:245)
    at de.metas.handlingunits.client.terminal.select.model.AbstractHUSelectModel.processRows(AbstractHUSelectModel.java:627)
Member

teosarca commented Dec 21, 2017

Hotfixed error when generating the receipt in Swing.
As as side effect, metasfresh/metasfresh#1905 shall be retested because on Swing the code introduced there was not executed, because the receipts were not collected.

The error stacktrace was:

Caused by: org.adempiere.exceptions.AdempiereException: Cannot provide the generated shipments because the result was not configured to retain them
    at de.metas.inoutcandidate.api.impl.DefaultInOutGenerateResult.getInOuts(DefaultInOutGenerateResult.java:87)
    at de.metas.handlingunits.receiptschedule.impl.HUReceiptScheduleBL.processReceiptSchedules0(HUReceiptScheduleBL.java:384)
    at de.metas.handlingunits.receiptschedule.impl.HUReceiptScheduleBL.lambda$0(HUReceiptScheduleBL.java:290)
    at org.adempiere.ad.trx.api.impl.TrxCallableWrappers$5.call(TrxCallableWrappers.java:222)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call0(AbstractTrxManager.java:771)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:683)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:584)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:515)
    at de.metas.handlingunits.receiptschedule.impl.HUReceiptScheduleBL.processReceiptSchedules(HUReceiptScheduleBL.java:290)
    at de.metas.handlingunits.client.terminal.select.api.impl.ReceiptScheduleFiltering.processRows(ReceiptScheduleFiltering.java:245)
    at de.metas.handlingunits.client.terminal.select.model.AbstractHUSelectModel.processRows(AbstractHUSelectModel.java:627)

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jan 5, 2018

update releaseNotes
[#768](metasfresh/metasfresh-webui-api#768)
Picking Tray Clearing: packing HUs: generate shipper's package label
[#3281](#3281)
C_Tax.ValidFrom bug
[#3272](#3272) Provide
Periods for 2018
[#741](metasfresh/metasfresh-webui-api#741)
WebUI window C_Printing_Queue broken
[#769](metasfresh/metasfresh-webui-api#769)
New context variable for isWebUI
[#764](metasfresh/metasfresh-webui-api#764)
Receipt candidates: HU editor: cannot call Transform for a CU
[#3237](#3237) New
Document "Source of Supply"
[#1465](metasfresh/metasfresh-webui-frontend#1465)
frontend: Processes: when calling a process frontend shall provide which
are the selected rows in the left/right view
[#3230](#3230) Pharma:
import prices
[#763](metasfresh/metasfresh-webui-api#763)
Picking Tray Clearing: packing HUs: Add to Transportation Order, Ship
and Invoice action
[#2822](#2822) Empty
Country in Price List not working
[#3238](#3238) Create
Missing M_Cost records on the fly
[#1752](#1752) System
Element overwrite on Window Field
[#3233](#3233) WebUI:
Role permission constraints missing in Subtabs
[#757](metasfresh/metasfresh-webui-api#757)
elasticsearch shall use slf4j instead of log4j
[#752](metasfresh/metasfresh-webui-api#752)
Picking Tray Clearing: picking slot filter no results
[#3227](#3227) Attachment
related perf problem in swing client
[#3155](#3155) Create
special pharma import product table
[#3225](#3225) Error on
unclosing a "manually" created PPOrder
[#3222](#3222) refactor
trx event listeners
[#758](metasfresh/metasfresh-webui-api#758)
Picking Tray Clearing: process to take out an HU and add it to existing
HU
[#760](metasfresh/metasfresh-webui-api#760)
Picking Tray Clearing: process to take out an HU and add it to new HU

@metas-dh metas-dh self-assigned this Jan 8, 2018

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Jan 8, 2018

Member

Results of IT1
tested in mf15

When the process is executed, it shall:

  • create M_Package(s), M_Package_HU(s) and link them to given Transportation Order:
    • M_Package (Packstück) is created: OK
    • M_Package linked to Transportation Order: OK (link wo window in tab Versandpackung)
    • M_Package_HU(s): not sure where to find this one?
  • the HUs added to the transportation order shall no longer be visible in the right side view, nor later: OK
  • create a shipment for those HUs (shipment schedules are updated correctly): OK
  • create an invoice for
    • all invoice candidates which are "linked" to those shipment schedules of those HUs: OK
    • invoice candidates which have a Invoice Schedule set are skipped. They will be invoiced on that schedule (e.g. monthly, weekly etc): to be tested
  • User shall get a notification when:
    • the shipment is generated: OK
    • the invoice is generated (if any): OK
    • something went wrong (e.g. invoice generate workpackage(s) failed): to be tested

=> calling process sometimes causes an error: metasfresh/metasfresh-webui-frontend#1495

questions:

  • when the invoice is created, the shipment schedule is closed, so if you use this process to create a partial shipment, no other shipments can be created for the resp. schedule: i guess this is wanted?

  • Transportation Order in WebUI: shows the M_ShipperTransportation_ID in tab Versandpackung, not the no. of the transportation order, but in Swing it's the no., why?

WebUI:
2018-01-08 14_11_52-metasfresh

Swing:
2018-01-08 14_12_35-decloudit001

still need to do:

  • regression make sure generating shipments from HUs still works in Swing
  • regression on generating Invoices
  • re-test metasfresh/metasfresh#1905
Member

metas-dh commented Jan 8, 2018

Results of IT1
tested in mf15

When the process is executed, it shall:

  • create M_Package(s), M_Package_HU(s) and link them to given Transportation Order:
    • M_Package (Packstück) is created: OK
    • M_Package linked to Transportation Order: OK (link wo window in tab Versandpackung)
    • M_Package_HU(s): not sure where to find this one?
  • the HUs added to the transportation order shall no longer be visible in the right side view, nor later: OK
  • create a shipment for those HUs (shipment schedules are updated correctly): OK
  • create an invoice for
    • all invoice candidates which are "linked" to those shipment schedules of those HUs: OK
    • invoice candidates which have a Invoice Schedule set are skipped. They will be invoiced on that schedule (e.g. monthly, weekly etc): to be tested
  • User shall get a notification when:
    • the shipment is generated: OK
    • the invoice is generated (if any): OK
    • something went wrong (e.g. invoice generate workpackage(s) failed): to be tested

=> calling process sometimes causes an error: metasfresh/metasfresh-webui-frontend#1495

questions:

  • when the invoice is created, the shipment schedule is closed, so if you use this process to create a partial shipment, no other shipments can be created for the resp. schedule: i guess this is wanted?

  • Transportation Order in WebUI: shows the M_ShipperTransportation_ID in tab Versandpackung, not the no. of the transportation order, but in Swing it's the no., why?

WebUI:
2018-01-08 14_11_52-metasfresh

Swing:
2018-01-08 14_12_35-decloudit001

still need to do:

  • regression make sure generating shipments from HUs still works in Swing
  • regression on generating Invoices
  • re-test metasfresh/metasfresh#1905
@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Jan 10, 2018

Member

Regression testing:

  • generating shipments from HUs still works in Swing:

    • generating shipments from shipment schedule for picked HUs: OK
    • generating shipments from Verdichtung POS for picked HUs: OK
    • generating shipments from shipment schedules without picked HUs: OK
  • regression on generating Invoices:

    • tested in Swing for the orders i created the different shipments for (see above): OK
    • tested in WebUI for the orders i created the different shipments for (see above): could not create an invoice for 1 order, but could not reproduce; working fine for the others
  • re-test metasfresh/metasfresh#1905:

    • tested in Swing: OK,
    • could not test in WebUI bc of Transform not working correctly (trying to reproduce and creating a task)
Member

metas-dh commented Jan 10, 2018

Regression testing:

  • generating shipments from HUs still works in Swing:

    • generating shipments from shipment schedule for picked HUs: OK
    • generating shipments from Verdichtung POS for picked HUs: OK
    • generating shipments from shipment schedules without picked HUs: OK
  • regression on generating Invoices:

    • tested in Swing for the orders i created the different shipments for (see above): OK
    • tested in WebUI for the orders i created the different shipments for (see above): could not create an invoice for 1 order, but could not reproduce; working fine for the others
  • re-test metasfresh/metasfresh#1905:

    • tested in Swing: OK,
    • could not test in WebUI bc of Transform not working correctly (trying to reproduce and creating a task)
@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Jan 11, 2018

Member

Update:

  • invoice candidates which have a Invoice Schedule set are skipped. They will be invoiced on that schedule (e.g. monthly, weekly etc):
    => Invoice Schedule for my IC was 14 days, but invoice was created anyway; IC still says "Date Invoice from eff.: 15.01.2018", invoice date is 11.01.2018
    @teosarca i think this is NOK?
Member

metas-dh commented Jan 11, 2018

Update:

  • invoice candidates which have a Invoice Schedule set are skipped. They will be invoiced on that schedule (e.g. monthly, weekly etc):
    => Invoice Schedule for my IC was 14 days, but invoice was created anyway; IC still says "Date Invoice from eff.: 15.01.2018", invoice date is 11.01.2018
    @teosarca i think this is NOK?
@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Jan 25, 2018

Member

created follow up: #806, closing this one.

Member

metas-dh commented Jan 25, 2018

created follow up: #806, closing this one.

@metas-dh metas-dh closed this Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment