From adb3057d3bbe405d11dc60d37a4730c058016d61 Mon Sep 17 00:00:00 2001
From: "damian.przygodzki" <damian.przygodzki@jazzy.pro>
Date: Thu, 16 Feb 2017 08:42:25 +0100
Subject: [PATCH] REFACTOR after linting #2 part

---
 .eslintrc                                           |  1 +
 src/components/app/LoginForm.js                     | 13 +++++++++----
 src/components/header/Breadcrumb.js                 |  4 ++--
 src/components/header/Header.js                     |  6 +++---
 .../shortcuts/DocumentListContextShortcuts.js       |  6 +++---
 .../shortcuts/DocumentStatusContextShortcuts.js     |  4 ++--
 src/components/shortcuts/GlobalContextShortcuts.js  |  4 ++--
 .../shortcuts/PaginationContextShortcuts.js         |  4 ++--
 .../shortcuts/QuickActionsContextShortcuts.js       |  6 +++---
 src/components/shortcuts/TableContextShortcuts.js   |  4 ++--
 src/components/table/Table.js                       |  4 ++--
 src/components/table/TableItem.js                   |  3 +--
 src/components/table/TablePagination.js             |  2 +-
 src/components/tabs/Tabs.js                         |  5 ++---
 src/components/widget/RawWidget.js                  |  4 ++--
 src/containers/Dashboard.js                         |  2 +-
 src/containers/InboxAll.js                          |  2 +-
 src/containers/NavigationTree.js                    |  2 +-
 18 files changed, 40 insertions(+), 36 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index 2647b9983..ad0574dd8 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -9,6 +9,7 @@
   },
   "parser": "babel-eslint",
   "rules": {
+    "esline:recommended": 2,
     "quotes": [2, "single"],
     "jsx-quotes": [2, "prefer-double"],
     "strict": [2, "never"],
diff --git a/src/components/app/LoginForm.js b/src/components/app/LoginForm.js
index 67ba89993..f89f0f280 100644
--- a/src/components/app/LoginForm.js
+++ b/src/components/app/LoginForm.js
@@ -110,7 +110,7 @@ class LoginForm extends Component {
                     <img src={logo} className="header-logo mt-2 mb-2" />
                 </div>
                 {roleSelect ? <div>
-                    <div className={"form-control-label"}><small>Select role</small></div>
+                    <div className="form-control-label"><small>Select role</small></div>
                         <RawList
                             rank="primary"
                             list={roles}
@@ -126,7 +126,7 @@ class LoginForm extends Component {
                             </div>
                         }
                         <div>
-                            <div className={"form-control-label"}><small>Login</small></div>
+                            <div className="form-control-label"><small>Login</small></div>
                             <input
                                 type="text"
                                 onChange={this.handleOnChange}
@@ -139,7 +139,7 @@ class LoginForm extends Component {
                                 ref={c => this.login = c} />
                         </div>
                         <div>
-                            <div className={"form-control-label"}><small>Password</small></div>
+                            <div className="form-control-label"><small>Password</small></div>
                             <input
                                 type="password"
                                 onChange={this.handleOnChange}
@@ -156,7 +156,12 @@ class LoginForm extends Component {
                     </div>
                 }
                 <div className="mt-2">
-                    <button className="btn btn-sm btn-block btn-meta-success" onClick={this.handleLogin}>{roleSelect? 'Send' : 'Login'}</button>
+                    <button 
+                        className="btn btn-sm btn-block btn-meta-success" 
+                        onClick={this.handleLogin}
+                    >
+                        {roleSelect? 'Send' : 'Login'}
+                    </button>
                 </div>
             </div>
         )
diff --git a/src/components/header/Breadcrumb.js b/src/components/header/Breadcrumb.js
index 3e5816c61..37fa87ee9 100644
--- a/src/components/header/Breadcrumb.js
+++ b/src/components/header/Breadcrumb.js
@@ -36,7 +36,7 @@ class Breadcrumb extends Component {
 
         return (<div key={index}>
             {!!index && <span className="divider">/</span>}
-            <div className={"header-btn tooltip-parent"}>
+            <div className="header-btn tooltip-parent">
                 <div
                     title={!!index && menu.children.captionBreadcrumb ? menu.children.captionBreadcrumb : ''}
                     className={'header-item-container pointer ' +
@@ -53,7 +53,7 @@ class Breadcrumb extends Component {
                     onMouseEnter={!!index ? '' : (e) => this.toggleTooltip(true)}
                     onMouseLeave={(e) => this.toggleTooltip(false)}
                 >
-                    <span className={"header-item icon-sm"}>
+                    <span className="header-item icon-sm">
                         {!!index ? menu.children.captionBreadcrumb : <i className="meta-icon-menu" />}
                     </span>
                 </div>
diff --git a/src/components/header/Header.js b/src/components/header/Header.js
index 83ca4b625..776fd2160 100644
--- a/src/components/header/Header.js
+++ b/src/components/header/Header.js
@@ -243,8 +243,8 @@ class Header extends Component {
             {
                 prompt.open &&
                 <Prompt
-                    title={"Delete"}
-                    text={"Are you sure?"}
+                    title="Delete"
+                    text="Are you sure?"
                     buttons={{submit: 'Delete', cancel: 'Cancel'}}
                     onCancelClick={this.handlePromptCancelClick}
                     onSubmitClick={() => this.handlePromptSubmitClick(windowType, dataId)}
@@ -328,7 +328,7 @@ class Header extends Component {
                                     onMouseEnter={(e) => this.toggleTooltip(keymap.GLOBAL_CONTEXT.OPEN_INBOX_MENU)}
                                     onMouseLeave={(e) => this.toggleTooltip('')}
                                 >
-                                    <span className={"header-item header-item-badge icon-lg"}>
+                                    <span className="header-item header-item-badge icon-lg">
                                         <i className="meta-icon-notifications" />
                                         {inbox.unreadCount > 0 && <span className="notification-number">{inbox.unreadCount}</span>}
                                     </span>
diff --git a/src/components/shortcuts/DocumentListContextShortcuts.js b/src/components/shortcuts/DocumentListContextShortcuts.js
index 21238675a..edb1eb234 100644
--- a/src/components/shortcuts/DocumentListContextShortcuts.js
+++ b/src/components/shortcuts/DocumentListContextShortcuts.js
@@ -37,9 +37,9 @@ class DocumentListContextShortcuts extends Component {
     render() {
         return (
         <Shortcuts
-            name={"DOCUMENT_LIST_CONTEXT"}
+            name="DOCUMENT_LIST_CONTEXT"
             handler = { this.handleShortcuts }
-            targetNodeSelector = { "body" }
+            targetNodeSelector="body"
             isolate = { true }
             preventDefault = { true }
             stopPropagation = { true } 
@@ -48,4 +48,4 @@ class DocumentListContextShortcuts extends Component {
     }
 }
 
-export default DocumentListContextShortcuts;
\ No newline at end of file
+export default DocumentListContextShortcuts;
diff --git a/src/components/shortcuts/DocumentStatusContextShortcuts.js b/src/components/shortcuts/DocumentStatusContextShortcuts.js
index de8c4363a..830e90064 100644
--- a/src/components/shortcuts/DocumentStatusContextShortcuts.js
+++ b/src/components/shortcuts/DocumentStatusContextShortcuts.js
@@ -16,9 +16,9 @@ class DocumentStatusContextShortcuts extends Component {
     render() {
         return (
             <Shortcuts
-                name={"DOCUMENT_STATUS_CONTEXT"}
+                name="DOCUMENT_STATUS_CONTEXT"
                 handler = { this.handleShortcuts }
-                targetNodeSelector = { "body" }
+                targetNodeSelector = "body"
                 isolate = { true }
                 preventDefault = { true }
                 stopPropagation = { true }
diff --git a/src/components/shortcuts/GlobalContextShortcuts.js b/src/components/shortcuts/GlobalContextShortcuts.js
index d3c62e51d..c63695e30 100644
--- a/src/components/shortcuts/GlobalContextShortcuts.js
+++ b/src/components/shortcuts/GlobalContextShortcuts.js
@@ -69,9 +69,9 @@ class GlobalContextShortcuts extends Component {
     render() {
         return (
             <Shortcuts
-                name = { "GLOBAL_CONTEXT" }
+                name = "GLOBAL_CONTEXT"
                 handler = { this.handleShortcuts }
-                targetNodeSelector = { "body" }
+                targetNodeSelector = "body"
                 isolate = { true }
                 preventDefault = { true }
                 stopPropagation = { true }
diff --git a/src/components/shortcuts/PaginationContextShortcuts.js b/src/components/shortcuts/PaginationContextShortcuts.js
index df28918b1..98fa5f1aa 100644
--- a/src/components/shortcuts/PaginationContextShortcuts.js
+++ b/src/components/shortcuts/PaginationContextShortcuts.js
@@ -27,9 +27,9 @@ class PaginationContextShortcuts extends Component {
     render() {
         return (
             <Shortcuts
-                name={"PAGINATION_CONTEXT"}
+                name="PAGINATION_CONTEXT"
                 handler = { this.handleShortcuts }
-                targetNodeSelector = { "body" }
+                targetNodeSelector = "body"
                 isolate = { true }
                 preventDefault = { true }
                 stopPropagation = { true }
diff --git a/src/components/shortcuts/QuickActionsContextShortcuts.js b/src/components/shortcuts/QuickActionsContextShortcuts.js
index 7883282ae..2c6b1f3ab 100644
--- a/src/components/shortcuts/QuickActionsContextShortcuts.js
+++ b/src/components/shortcuts/QuickActionsContextShortcuts.js
@@ -19,9 +19,9 @@ class DocumentListContextShortcuts extends Component {
     render() {
         return (
         <Shortcuts
-            name={"QUICK_ACTIONS"}
+            name="QUICK_ACTIONS"
             handler = { this.handleShortcuts }
-            targetNodeSelector = { "body" }
+            targetNodeSelector = "body"
             isolate = { true }
             preventDefault = { true }
             stopPropagation = { true } 
@@ -30,4 +30,4 @@ class DocumentListContextShortcuts extends Component {
     }
 }
 
-export default DocumentListContextShortcuts;
\ No newline at end of file
+export default DocumentListContextShortcuts;
diff --git a/src/components/shortcuts/TableContextShortcuts.js b/src/components/shortcuts/TableContextShortcuts.js
index 02a97318e..dbed4a8fd 100644
--- a/src/components/shortcuts/TableContextShortcuts.js
+++ b/src/components/shortcuts/TableContextShortcuts.js
@@ -24,9 +24,9 @@ class TableContextShortcuts extends Component {
     render() {
         return (
             <Shortcuts
-                name={"TABLE_CONTEXT"}
+                name="TABLE_CONTEXT"
                 handler = { this.handleShortcuts }
-                targetNodeSelector = { "body" }
+                targetNodeSelector = "body"
                 isolate = { true }
                 preventDefault = { true }
                 stopPropagation = { true }
diff --git a/src/components/table/Table.js b/src/components/table/Table.js
index 5bff4e7ee..8ef2d3347 100644
--- a/src/components/table/Table.js
+++ b/src/components/table/Table.js
@@ -732,8 +732,8 @@ class Table extends Component {
                 }
                 {promptOpen &&
                     <Prompt
-                        title={"Delete"}
-                        text={"Are you sure?"}
+                        title="Delete"
+                        text="Are you sure?"
                         buttons={{submit: 'Delete', cancel: 'Cancel'}}
                         onCancelClick={this.handlePromptCancelClick}
                         onSubmitClick={() => this.handlePromptSubmitClick(selected)}
diff --git a/src/components/table/TableItem.js b/src/components/table/TableItem.js
index b886dfdf9..578055aae 100644
--- a/src/components/table/TableItem.js
+++ b/src/components/table/TableItem.js
@@ -156,8 +156,7 @@ class TableItem extends Component {
             indentation.push(
                 <div
                     key={i}
-                    className={"indent-item-mid "
-                    }
+                    className="indent-item-mid"
                 >
                     {i === indent.length - 1 && <div className="indent-mid"/>}
                     <div
diff --git a/src/components/table/TablePagination.js b/src/components/table/TablePagination.js
index 0081e42b9..d46ec9684 100644
--- a/src/components/table/TablePagination.js
+++ b/src/components/table/TablePagination.js
@@ -189,7 +189,7 @@ class TablePagination extends Component {
 
                                     {pagination}
 
-                                    <li className={"page-item "}>
+                                    <li className="page-item ">
                                         <a className="page-link" onClick={() => {handleChangePage('up'); deselect()} }>
                                             <span>&raquo;</span>
                                         </a>
diff --git a/src/components/tabs/Tabs.js b/src/components/tabs/Tabs.js
index 0fd275ecd..2ab0682f2 100644
--- a/src/components/tabs/Tabs.js
+++ b/src/components/tabs/Tabs.js
@@ -64,7 +64,7 @@ class Tabs extends Component {
                 return (
                     <div
                         key={'pane' + item.key}
-                        className={"tab-pane active"}
+                        className="tab-pane active"
                     >
                         {itemWithProps}
                     </div>
@@ -78,7 +78,6 @@ class Tabs extends Component {
 
     render() {
         const {children, tabIndex, fullScreen} = this.props;
-        // const {fullScreen} = this.state;
         return (
             <div className={
                 'mb-1 ' +
@@ -88,7 +87,7 @@ class Tabs extends Component {
                     {this.renderPills(children)}
                 </ul>
                 <div
-                    className={"tab-content"}
+                    className="tab-content"
                     tabIndex={tabIndex}
                     ref={c => this.tabContent = c}
                 >
diff --git a/src/components/widget/RawWidget.js b/src/components/widget/RawWidget.js
index d1d12757c..d75d8a011 100644
--- a/src/components/widget/RawWidget.js
+++ b/src/components/widget/RawWidget.js
@@ -462,7 +462,7 @@ class RawWidget extends Component {
                             onChange={(e) => this.handlePatch(widgetField, e.target.checked, id)}
                             tabIndex="-1"
                         />
-                        <div className={"input-checkbox-tick"}/>
+                        <div className="input-checkbox-tick" />
                     </label>
                 )
             case 'Switch':
@@ -483,7 +483,7 @@ class RawWidget extends Component {
                             tabIndex="-1"
                             onChange={(e) => this.handlePatch(widgetField, e.target.checked, id)}
                         />
-                        <div className={"input-slider"} />
+                        <div className="input-slider" />
                     </label>
                 )
             case 'Label':
diff --git a/src/containers/Dashboard.js b/src/containers/Dashboard.js
index c5b0e044c..98f3bb186 100644
--- a/src/containers/Dashboard.js
+++ b/src/containers/Dashboard.js
@@ -13,7 +13,7 @@ export class Dashboard extends Component {
         const {breadcrumb} = this.props;
         return (
             <Container
-                siteName = {"Dashboard"}
+                siteName = "Dashboard"
                 noMargin = {true}
             >
                 <div className="container-fluid dashboard-wrapper">
diff --git a/src/containers/InboxAll.js b/src/containers/InboxAll.js
index 17f45664a..21766911d 100644
--- a/src/containers/InboxAll.js
+++ b/src/containers/InboxAll.js
@@ -14,7 +14,7 @@ class InboxAll extends Component {
 
         return (
             <Container
-                siteName = {"Inbox"}
+                siteName = "Inbox"
             >
                 <Inbox
                     all={true}
diff --git a/src/containers/NavigationTree.js b/src/containers/NavigationTree.js
index 87e5b2604..737c62af5 100644
--- a/src/containers/NavigationTree.js
+++ b/src/containers/NavigationTree.js
@@ -187,7 +187,7 @@ class NavigationTree extends Component {
         return (
             <Container
                 breadcrumb={breadcrumb.slice(0,1)}
-                siteName = {"Sitemap"}
+                siteName = "Sitemap"
             >
                 {modal.visible &&
                     <Modal