diff --git a/src/components/charts/BarChartComponent/data.js b/src/components/charts/BarChartComponent/data.js index a4d6e75db..aa814458f 100644 --- a/src/components/charts/BarChartComponent/data.js +++ b/src/components/charts/BarChartComponent/data.js @@ -104,11 +104,7 @@ export const drawData = ( if (yChanged || reRender) { return dimensions.height; } else { - if (d.valuePrev < 0) { - return ranges.y(0); - } else { - return ranges.y(d.valuePrev); - } + return getY(d.valuePrev, ranges); } }) .attr("height", d => { @@ -121,12 +117,16 @@ export const drawData = ( .transition() .duration(1000) .attr("y", d => { - if (d.value < 0) { - return ranges.y(0); - } else { - return ranges.y(d.value); - } + return getY(d.value, ranges); }) .attr("height", d => Math.abs(ranges.y(d.value) - ranges.y(0))) .attr("fill", d => ranges.z(d.key)); }; + +function getY(value, ranges) { + if (value < 0) { + return ranges.y(0); + } else { + return ranges.y(value); + } +}