New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use automatic code style enforcement #1206

Closed
PabloSichert opened this Issue Sep 19, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@PabloSichert
Contributor

PabloSichert commented Sep 19, 2017

Type of issue

Feature request

Current behavior

Files are linted but corrections are not automatically enforced / not fixable with the current configuration of ESLint.

Expected behavior

Automatically transform code to match the code styling rules. Helps a lot with productivity and consistency: unused variables are removed, lines wider than 80 characters are wrapped, all indentation is done automatically, etc. I'm thinking of configuring this tool https://github.com/prettier/prettier with the existing ESLint config. It's the "JS version of gofmt", if someone's familiar with that.

Interested on what you think about that!

This was referenced Oct 9, 2017

teosarca added a commit that referenced this issue Dec 11, 2017

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 11, 2017

Member

note to IT: pls check the overall stability. e2e would be OK for this task to pass.

Member

teosarca commented Dec 11, 2017

note to IT: pls check the overall stability. e2e would be OK for this task to pass.

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 18, 2017

Update ReleaseNotes.md
[#706](metasfresh/metasfresh-webui-api#706)
Port current MRP Product Info Window to the webui
[#755](metasfresh/metasfresh-webui-api#755)
Processes: support for parentViewSelectedIds and childViewSelectedIds
[#1427](metasfresh/metasfresh-webui-frontend#1427)
d3 errors on dashboard
[#2646](#2646) MRP
Product Info Just in Time
[#751](metasfresh/metasfresh-webui-api#751)
Picking Tray Clearing: packing HUs: Add to Transportation Order action
[#1437](metasfresh/metasfresh-webui-frontend#1437)
Language bug: The language in Settings is not respected
[#746](metasfresh/metasfresh-webui-api#746)
Picking Tray Clearing: Scan picking slot barcode filter
[#1455](metasfresh/metasfresh-webui-frontend#1455)
error when updating an attribute multiple times
[#747](metasfresh/metasfresh-webui-api#747)
Picking Tray Clearing: filter picking slots by Partner
[#1433](metasfresh/metasfresh-webui-frontend#1433)
Support Lookup view attributes
[#3211](#3211) Picking
Tray Clearing: right side view shall display only the HUs for current
BP/Location
[#1444](metasfresh/metasfresh-webui-frontend#1444)
Attributes are empty in material receipt candidate
[#3202](#3202) Error in
Paymentjournal Process/ Report in Payselection
[#3193](#3193) Improve
Window for manual OnHand Qty in WebUI
[#1448](metasfresh/metasfresh-webui-frontend#1448)
jenkins: fix current lint issues
[#1435](metasfresh/metasfresh-webui-frontend#1435)
Problem regarding multiple filters
[#1436](metasfresh/metasfresh-webui-frontend#1436)
Remove legacy docs
[#3169](#3169) Updating
PMM_Week availability trend fails
[#1206](metasfresh/metasfresh-webui-frontend#1206)
Use automatic code style enforcement
[#717](metasfresh/metasfresh-webui-api#717)
picking terminal: open HUs to pick shall display Best Before date and
Locator

me-45

@metas-mk metas-mk closed this Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment