New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the legacy view attributes API #1357

Closed
teosarca opened this Issue Nov 20, 2017 · 24 comments

Comments

Projects
None yet
5 participants
@teosarca
Member

teosarca commented Nov 20, 2017

Instead of using
http://w101.metasfresh.com:8081/swagger-ui.html#/view-row-attributes-rest-controller-_-old

please always use
http://w101.metasfresh.com:8081/swagger-ui.html#/view-row-attributes-rest-controller

That legacy API is scheduled to be deleted. It already caused a lot of confusion.

Note to IT:

  • check view attributes (setting, dropdown) => no errors
  • briefly test creating a new document (e.g. a new sales order) => no errors
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 21, 2017

Member

@wiadev also check the documentation/discussion from #1184 (duplicate of this one)

Member

teosarca commented Nov 21, 2017

@wiadev also check the documentation/discussion from #1184 (duplicate of this one)

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Nov 24, 2017

Member

@teosarca fixed calling wrong api after editing/patching on the following modal under this task we discussed last time.

screenshot at nov 24 09-46-57

can you give me the use cases using old apis?

Member

wiadev commented Nov 24, 2017

@teosarca fixed calling wrong api after editing/patching on the following modal under this task we discussed last time.

screenshot at nov 24 09-46-57

can you give me the use cases using old apis?

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Nov 24, 2017

how to test attributes

  1. go to receipt candidates window: https://w101.metasfresh.com:8443/window/540196?viewId=540196-06faf33c94f14604ac8662311a3055a8&page=1
  2. select any line (e.g. one for convenence salad)
  3. select the main action (e.g. green button: 1 IFCO 6410 x 10 Stk)
  4. modify some attributes while being on LU level:
    =>
    when you edit gewicht brutto notice gewicht netto updates
    when you update tageslot lot-nummer updates
    most attributes you modify on LU level, will update on TU level as well
    cu level doesn't support attributes

metas-lc commented Nov 24, 2017

how to test attributes

  1. go to receipt candidates window: https://w101.metasfresh.com:8443/window/540196?viewId=540196-06faf33c94f14604ac8662311a3055a8&page=1
  2. select any line (e.g. one for convenence salad)
  3. select the main action (e.g. green button: 1 IFCO 6410 x 10 Stk)
  4. modify some attributes while being on LU level:
    =>
    when you edit gewicht brutto notice gewicht netto updates
    when you update tageslot lot-nummer updates
    most attributes you modify on LU level, will update on TU level as well
    cu level doesn't support attributes
@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Nov 24, 2017

Member

@teosarca can you point out where I can find subentity/subentityId apis on swagger ui doc?
Also, usage of isAdvanced query param.

Member

wiadev commented Nov 24, 2017

@teosarca can you point out where I can find subentity/subentityId apis on swagger ui doc?
Also, usage of isAdvanced query param.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 25, 2017

Member

@wiadev let's talk when u have time. I don't understand your request :(

Member

teosarca commented Nov 25, 2017

@wiadev let's talk when u have time. I don't understand your request :(

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Nov 28, 2017

Member

another use case to get attributes after discussing with @teosarca
https://w101.metasfresh.com:8443/window/540189

Member

wiadev commented Nov 28, 2017

another use case to get attributes after discussing with @teosarca
https://w101.metasfresh.com:8443/window/540189

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Nov 29, 2017

Member

@teosarca
screenshot at nov 29 16-57-32
check out the above screenshot and could you point out why it doesn't work?

Member

wiadev commented Nov 29, 2017

@teosarca
screenshot at nov 29 16-57-32
check out the above screenshot and could you point out why it doesn't work?

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev
Member

wiadev commented Nov 29, 2017

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 29, 2017

Member

@wiadev

check out the above screenshot and could you point out why it doesn't work?
same issue on http://localhost:3000/window/540189?viewId=540189-d9970cd0d9764f67b6d1e44bfbfba4b7&page=1 when I select the last includedDocument.

Yup that's happening because the row level supportAttributes property is not considered.
See task: #1393

image

Member

teosarca commented Nov 29, 2017

@wiadev

check out the above screenshot and could you point out why it doesn't work?
same issue on http://localhost:3000/window/540189?viewId=540189-d9970cd0d9764f67b6d1e44bfbfba4b7&page=1 when I select the last includedDocument.

Yup that's happening because the row level supportAttributes property is not considered.
See task: #1393

image

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Nov 29, 2017

Member

@teosarca understood
since we have a new follow-up issue, can we close this issue after merge #1392 ?

Member

wiadev commented Nov 29, 2017

@teosarca understood
since we have a new follow-up issue, can we close this issue after merge #1392 ?

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 29, 2017

Member

@wiadev nop, the issue will be closed by the integration testing team after they will perform all tests + regression.
That's our standard procedure.

Member

teosarca commented Nov 29, 2017

@wiadev nop, the issue will be closed by the integration testing team after they will perform all tests + regression.
That's our standard procedure.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 29, 2017

Member

but they will know about that follow-up and will not fail the task because of that.

Member

teosarca commented Nov 29, 2017

but they will know about that follow-up and will not fail the task because of that.

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Nov 29, 2017

Member

@teosarca got it.
I meant by moving to testing team.

Member

wiadev commented Nov 29, 2017

@teosarca got it.
I meant by moving to testing team.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 29, 2017

Member

yes, ofc.
but before i will do some quick preliminary tests. One thing that i forgot to tell you and now pops in my mind, and I HOPE it's not related is about editing product attributes.

e.g.
image

Member

teosarca commented Nov 29, 2017

yes, ofc.
but before i will do some quick preliminary tests. One thing that i forgot to tell you and now pops in my mind, and I HOPE it's not related is about editing product attributes.

e.g.
image

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 29, 2017

Member

update: it seems the view attributes code has nothing to do with product attributes (the ones from above). So it's fine.
@wiadev can u also confirm this?

Member

teosarca commented Nov 29, 2017

update: it seems the view attributes code has nothing to do with product attributes (the ones from above). So it's fine.
@wiadev can u also confirm this?

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Nov 30, 2017

Member

@teosarca confirmed that viewAttributes code has nothing to do with product attributes.
It's using another getAttributeInstances() methods which is POST /api/pattribute

Member

wiadev commented Nov 30, 2017

@teosarca confirmed that viewAttributes code has nothing to do with product attributes.
It's using another getAttributeInstances() methods which is POST /api/pattribute

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 30, 2017

Member

@wiadev perfect, 10x.

Member

teosarca commented Nov 30, 2017

@wiadev perfect, 10x.

teosarca added a commit that referenced this issue Dec 3, 2017

teosarca added a commit that referenced this issue Dec 3, 2017

Merge pull request #1402 from metasfresh/dev-1357
Update attributes & dropdown api #1357

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Dec 3, 2017

metas-ts added a commit that referenced this issue Dec 4, 2017

Create getViewAttributesLayout() #1357
- Fix deprecated api with new api - getViewAttributesLayout

(cherry picked from commit af25474)

metas-ts added a commit that referenced this issue Dec 4, 2017

metas-ts added a commit that referenced this issue Dec 4, 2017

hotfix #1357
(cherry picked from commit 43e0828)

solved Conflicts:
	src/actions/GenericActions.js

metas-ts added a commit that referenced this issue Dec 4, 2017

extract view attributes related functions to ViewAttributesAction.js
#1357

@wiadev  pls review

(cherry picked from commit 1f4e3d6)

solved Conflicts:
	src/actions/GenericActions.js

metas-ts added a commit that referenced this issue Dec 4, 2017

metas-ts added a commit that referenced this issue Dec 4, 2017

metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Dec 4, 2017

@metas-ts

This comment has been minimized.

Show comment
Hide comment
@metas-ts

metas-ts Dec 4, 2017

Member

cherry-picked into the release branch

Member

metas-ts commented Dec 4, 2017

cherry-picked into the release branch

metas-ts referenced this issue Dec 8, 2017

metas-ts added a commit that referenced this issue Dec 8, 2017

Create getViewAttributesLayout() #1357
- Fix deprecated api with new api - getViewAttributesLayout

(cherry picked from commit af25474)
@metas-ts

This comment has been minimized.

Show comment
Hide comment
@metas-ts

metas-ts Dec 8, 2017

Member

CPed the remaining commits to release too

Member

metas-ts commented Dec 8, 2017

CPed the remaining commits to release too

metas-ts added a commit that referenced this issue Dec 8, 2017

teosarca added a commit that referenced this issue Dec 8, 2017

@metas-rc

This comment has been minimized.

Show comment
Hide comment
@metas-rc

metas-rc Dec 13, 2017

Member

Note: IT only after #1441 is properly integrated.

Member

metas-rc commented Dec 13, 2017

Note: IT only after #1441 is properly integrated.

@metas-lc metas-lc self-assigned this Dec 19, 2017

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Dec 19, 2017

IT
tested attributes in orderlines, manufacturing OK
tested in hu editor from material receipt OK
made a task for a special case: #1468
in hu editor, if you set an attribute from none (null) to none you get an error

metas-lc commented Dec 19, 2017

IT
tested attributes in orderlines, manufacturing OK
tested in hu editor from material receipt OK
made a task for a special case: #1468
in hu editor, if you set an attribute from none (null) to none you get an error

@metas-lc metas-lc closed this Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment