New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View field editor: make sure the field value is sent to backend before the view is deleted #1361

Closed
teosarca opened this Issue Nov 20, 2017 · 2 comments

Comments

Projects
None yet
7 participants
@teosarca
Member

teosarca commented Nov 20, 2017

Is this a bug or feature request?

Bug
follow-up of #1335
part of metasfresh/metasfresh-webui-api#664

What is the current behavior?

Which are the steps to reproduce?* open a draft sales order, e.g. https://w101.metasfresh.com:8443/window/143/1000096

  • select the order lines and call the Create purchase order action
  • edit a field value and directly press "Done" to close the modal
    => NOK: error because the field is patched after the view is deleted.

image

What is the expected or desired behavior?

Shall work.

If there is a chance, even if it's small, to not send back some fields then I highly suggest, on Done,
please also consider sending ALL edited fields.
It's super important to have 100% correct and up2date values.

Another thing, if, for some reason the "DELETE view" endpoint which is called on Done fails, please don't close the modal.

@wiadev wiadev self-assigned this Nov 22, 2017

wiadev added a commit that referenced this issue Dec 1, 2017

Send editable fields' values to backend before view is deleted #1361
- Move view_editor_render_mode values in constants.js
- Create patchAll action in WindowActions

teosarca added a commit that referenced this issue Dec 3, 2017

Merge pull request #1399 from metasfresh/dev-1361
Send editable fields' values to backend before view is deleted #1361

@metas-lc metas-lc self-assigned this Dec 4, 2017

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Dec 4, 2017

IT
i don't really have a clear testcase for this, but i managed to reproduce the "no view found" after trying the same thing several times
(and notice edit appears several times. Maybe you can put them together if they are for the same row? like qty and date promised in the same request?)
go to https://w101.metasfresh.com:8443/window/143/1000096
e.g. select the first line, go to actions - create purchase orders
update a qty using keyboard then press done => works
select the first line and go to actions - create purchase orders
update the qty again using keyboard then press done => error
(you might need to do this 2 or 3 times...try to update the same qty field)
image

metas-lc commented Dec 4, 2017

IT
i don't really have a clear testcase for this, but i managed to reproduce the "no view found" after trying the same thing several times
(and notice edit appears several times. Maybe you can put them together if they are for the same row? like qty and date promised in the same request?)
go to https://w101.metasfresh.com:8443/window/143/1000096
e.g. select the first line, go to actions - create purchase orders
update a qty using keyboard then press done => works
select the first line and go to actions - create purchase orders
update the qty again using keyboard then press done => error
(you might need to do this 2 or 3 times...try to update the same qty field)
image

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 10, 2017

Update ReleaseNotpes.md
[#727](metasfresh/metasfresh-webui-api#727)
Allow search of Subproducer
[#3079](#3079) Warehouse
picking group
[#1421](metasfresh/metasfresh-webui-frontend#1421)
Drop down lists remain displayed when using tab several times
[#3150](#3150) Always
keep Terms & Conditions equal per Compensation Group
[#714](metasfresh/metasfresh-webui-api#714)
login authenticate: provide an unique key for each JSONLoginRole
[#1404](metasfresh/metasfresh-webui-frontend#1404)
login form selects 2 items from roles dropdown
[#3174](#3174) Material
Receipt Candidates not generates when using Purchase Order from Sales
Order action
[#1406](metasfresh/metasfresh-webui-frontend#1406)
Can not enter "-" into any text field
[#721](metasfresh/metasfresh-webui-api#721)
picking terminal: HUs to pick: scan/filter by Locator
[#722](metasfresh/metasfresh-webui-api#722)
picking terminal: picking slot rows shall NOT have duplicate IDs
[#3139](#3139) Cannot
edit System Administrator role (AD_Role_ID=0)
[#1396](metasfresh/metasfresh-webui-frontend#1396)
View field editor: Patch request isn't sent after hit enter
[#3171](#3171) Add view
to keep track of unprocessed async work packages
[#3149](#3149) Automatic
Discount for Group Products
[#1414](metasfresh/metasfresh-webui-frontend#1414)
view: don't allow user to sort by a given column if layout says so
[#1425](metasfresh/metasfresh-webui-frontend#1425)
eslint: increase line max-len from 80 to 120.
[#716](metasfresh/metasfresh-webui-api#716)
picking terminal: scan picking slot by barcode
[#723](metasfresh/metasfresh-webui-api#723)
picking terminal: HUs to pick: Pick CUs process
[#3137](#3137) Clean
C_PaySelection
[#3160](#3160)
C_Printing_Queue_ReEnqueue with IsSelected doesn't work
[#713](metasfresh/metasfresh-webui-api#713)
Error creating bean with name 'scopedTarget.internalUserSessionData'
[#1383](metasfresh/metasfresh-webui-frontend#1383)
cannot completely delete a numeric field in grid view
[#3138](#3138) Import
BPartner window: cannot see data
[#2340](#2340) Relation
Type: changelog
[#3151](#3151)
ZoomTo-Performance Issues
[#3147](#3147) Errors wrt
C_BPartner SQL columns
[#2338](#2338) Relation
Type: fact_accounts
[#3110](#3110) Request
All does not show records
[#1407](metasfresh/metasfresh-webui-frontend#1407)
process result: open included view: handle profileId property
[#3105](#3105) Improve
Product import process
[#711](metasfresh/metasfresh-webui-api#711)
picking terminal: additional shall support grouping lines by order
[#3058](#3058)
TableRecordId relation types to support Prefix_AD_Table_ID and
Prefix_Record_ID
[#3126](#3126) Solve
issues around standalone report / jasper service
[#1393](metasfresh/metasfresh-webui-frontend#1393)
View attributes: consider row's supportAttributes property before
querying for attributes
[#1361](metasfresh/metasfresh-webui-frontend#1361)
View field editor: make sure the field value is sent to backend before
the view is deleted

@teosarca teosarca assigned ottosichert and PabloSichert and unassigned wiadev Dec 20, 2017

PabloSichert added a commit that referenced this issue Jan 13, 2018

PabloSichert added a commit that referenced this issue Jan 13, 2018

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Jan 22, 2018

IT
repeated the testcase above. Works fine: error doesn't appear in that case. Also those edits don't appear OK
still, there is a case when that error pops up: when you change a qty in "Create purchase orders" and pressing done directly. Created follow-up #1518

metas-lc commented Jan 22, 2018

IT
repeated the testcase above. Works fine: error doesn't appear in that case. Also those edits don't appear OK
still, there is a case when that error pops up: when you change a qty in "Create purchase orders" and pressing done directly. Created follow-up #1518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment