New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View attributes: consider row's supportAttributes property before querying for attributes #1393

Closed
teosarca opened this Issue Nov 29, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@teosarca
Member

teosarca commented Nov 29, 2017

Is this a bug or feature request?

bug

What is the current behavior?

If view layout has supportAttributes:true then frontend is always querying for attributes.

Which are the steps to reproduce?

See #1357 (comment)

image

What is the expected or desired behavior?

Querying for view attributes if

  • layout has supportAttributes:true (as it is now)
  • AND the row does NOT have supportAttributes:false. If is true or missing, it shall be ignored.

@teosarca teosarca added the type:bug label Nov 29, 2017

@wiadev wiadev self-assigned this Nov 30, 2017

wiadev added a commit that referenced this issue Dec 2, 2017

Consider row's supportAttributes property before querying for attribu…
…tes #1393

- create getRowsData action in WindowsActions
- add supportAttribute props in SelectAttribute component

teosarca added a commit that referenced this issue Dec 3, 2017

Merge pull request #1401 from metasfresh/dev-1393
Consider row's supportAttributes property before querying #1393
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 4, 2017

Member

got following issue while playing in picking.
Steps are something like:

  • picking https://w101.metasfresh.com:8443/window/540345
  • select some lines and call Pick
  • make sure on left side you have several lines
  • pick on first line, select some picking slot, "open HUs to pick"
  • on left side, select the second line
    => sometimes, when you do things like this, application crashes and the screen remains blank.
    In console i got:

image

NOTE: i am on it

Member

teosarca commented Dec 4, 2017

got following issue while playing in picking.
Steps are something like:

  • picking https://w101.metasfresh.com:8443/window/540345
  • select some lines and call Pick
  • make sure on left side you have several lines
  • pick on first line, select some picking slot, "open HUs to pick"
  • on left side, select the second line
    => sometimes, when you do things like this, application crashes and the screen remains blank.
    In console i got:

image

NOTE: i am on it

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 4, 2017

Member

fixed.
@wiadev can u pls review: 5eace26

Member

teosarca commented Dec 4, 2017

fixed.
@wiadev can u pls review: 5eace26

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 10, 2017

Update ReleaseNotpes.md
[#727](metasfresh/metasfresh-webui-api#727)
Allow search of Subproducer
[#3079](#3079) Warehouse
picking group
[#1421](metasfresh/metasfresh-webui-frontend#1421)
Drop down lists remain displayed when using tab several times
[#3150](#3150) Always
keep Terms & Conditions equal per Compensation Group
[#714](metasfresh/metasfresh-webui-api#714)
login authenticate: provide an unique key for each JSONLoginRole
[#1404](metasfresh/metasfresh-webui-frontend#1404)
login form selects 2 items from roles dropdown
[#3174](#3174) Material
Receipt Candidates not generates when using Purchase Order from Sales
Order action
[#1406](metasfresh/metasfresh-webui-frontend#1406)
Can not enter "-" into any text field
[#721](metasfresh/metasfresh-webui-api#721)
picking terminal: HUs to pick: scan/filter by Locator
[#722](metasfresh/metasfresh-webui-api#722)
picking terminal: picking slot rows shall NOT have duplicate IDs
[#3139](#3139) Cannot
edit System Administrator role (AD_Role_ID=0)
[#1396](metasfresh/metasfresh-webui-frontend#1396)
View field editor: Patch request isn't sent after hit enter
[#3171](#3171) Add view
to keep track of unprocessed async work packages
[#3149](#3149) Automatic
Discount for Group Products
[#1414](metasfresh/metasfresh-webui-frontend#1414)
view: don't allow user to sort by a given column if layout says so
[#1425](metasfresh/metasfresh-webui-frontend#1425)
eslint: increase line max-len from 80 to 120.
[#716](metasfresh/metasfresh-webui-api#716)
picking terminal: scan picking slot by barcode
[#723](metasfresh/metasfresh-webui-api#723)
picking terminal: HUs to pick: Pick CUs process
[#3137](#3137) Clean
C_PaySelection
[#3160](#3160)
C_Printing_Queue_ReEnqueue with IsSelected doesn't work
[#713](metasfresh/metasfresh-webui-api#713)
Error creating bean with name 'scopedTarget.internalUserSessionData'
[#1383](metasfresh/metasfresh-webui-frontend#1383)
cannot completely delete a numeric field in grid view
[#3138](#3138) Import
BPartner window: cannot see data
[#2340](#2340) Relation
Type: changelog
[#3151](#3151)
ZoomTo-Performance Issues
[#3147](#3147) Errors wrt
C_BPartner SQL columns
[#2338](#2338) Relation
Type: fact_accounts
[#3110](#3110) Request
All does not show records
[#1407](metasfresh/metasfresh-webui-frontend#1407)
process result: open included view: handle profileId property
[#3105](#3105) Improve
Product import process
[#711](metasfresh/metasfresh-webui-api#711)
picking terminal: additional shall support grouping lines by order
[#3058](#3058)
TableRecordId relation types to support Prefix_AD_Table_ID and
Prefix_Record_ID
[#3126](#3126) Solve
issues around standalone report / jasper service
[#1393](metasfresh/metasfresh-webui-frontend#1393)
View attributes: consider row's supportAttributes property before
querying for attributes
[#1361](metasfresh/metasfresh-webui-frontend#1361)
View field editor: make sure the field value is sent to backend before
the view is deleted

@metas-lc metas-lc self-assigned this Dec 12, 2017

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Dec 12, 2017

IT

  1. hu editor
    => open it only with CUs - supportAttributes:true, attributes are queried OK
    => open it with TUs and/or LUs
    TU only - supportAttributes:true, attributes are queried OK
    TU and LU -supportAttributes:false, attributes are not queried OK
    (actually in case the HUs are aggregated, supportAttributes will be false on CU level)

  2. tried the picking testcase above several times - no errors OK

  3. tested step 1 in manufacturing as well. => works the same OK

metas-lc commented Dec 12, 2017

IT

  1. hu editor
    => open it only with CUs - supportAttributes:true, attributes are queried OK
    => open it with TUs and/or LUs
    TU only - supportAttributes:true, attributes are queried OK
    TU and LU -supportAttributes:false, attributes are not queried OK
    (actually in case the HUs are aggregated, supportAttributes will be false on CU level)

  2. tried the picking testcase above several times - no errors OK

  3. tested step 1 in manufacturing as well. => works the same OK

@metas-lc metas-lc closed this Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment