New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View field editor: Patch request isn't sent after hit enter #1396

Closed
wiadev opened this Issue Nov 30, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@wiadev
Member

wiadev commented Nov 30, 2017

Is this a bug or feature request?

Bug
follow-up of #1358

What is expected:

Needs to send a Patch request after hit enter

@wiadev wiadev self-assigned this Nov 30, 2017

wiadev added a commit that referenced this issue Dec 5, 2017

@wiadev wiadev closed this Dec 5, 2017

@wiadev wiadev reopened this Dec 5, 2017

wiadev added a commit that referenced this issue Dec 5, 2017

handle keydown on RawWidget #1396
- send edit request after hit enter
- remove handlekeydown from tableItem
- remove forceKeyBind state from tableItem

teosarca added a commit that referenced this issue Dec 6, 2017

Merge pull request #1413 from metasfresh/dev-1396
handle keydown on RawWidget #1396
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 6, 2017

Member

note to IT:
test how pressing enter in various text/number fields is behaving

Member

teosarca commented Dec 6, 2017

note to IT:
test how pressing enter in various text/number fields is behaving

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Dec 8, 2017

IT

I. normal vindow

A. grid view

  1. open e.g. product price window

  2. edit a price field, press enter
    (for now only numeric fields are editable in grid view)
    => patch request sent. OK
    => the cursor is still in that field. OK

  3. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is sent OK

B. Document vew

  1. open e.g. product price window and select a line - open doc view

  2. start editing a search field, press enter
    => patch sent OK

  3. same, edit numeric, dropdown and text fields
    => patch sent OK

  4. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is not sent NOK
    (if you refresh the page you will see the last value that was set. Not the new one)

  5. edit a date field, press enter
    => patch is not sent NOK

C. Included tab

  1. go to e.g. sales order, create a new one and add a line

  2. edit numeric, dropdown fields, press enter
    => patch sent OK

  3. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is not sent NOK

  4. edit a date field, press enter (e.g. Product windoww, cu-tu allocation tab)
    => patch is not sent NOK

II. modal window

A. Process

  1. create a sales order, add a line, select the line

  2. go to actions, run "Create Purchase Orders"

  3. edit qty
    => patch is sent OK

  4. edit date
    => patch is not sent NOK

  5. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is sent OK

B. Advanced Edit

  1. product sales order window, open advanced edit

  2. edit a numeric field or a text field, press enter, then edit it again without leaving the field
    => patch is not sent NOK

  3. edit a date field, press enter
    => patch is not sent NOK

Created follow-up for the NOKs: #1430

metas-lc commented Dec 8, 2017

IT

I. normal vindow

A. grid view

  1. open e.g. product price window

  2. edit a price field, press enter
    (for now only numeric fields are editable in grid view)
    => patch request sent. OK
    => the cursor is still in that field. OK

  3. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is sent OK

B. Document vew

  1. open e.g. product price window and select a line - open doc view

  2. start editing a search field, press enter
    => patch sent OK

  3. same, edit numeric, dropdown and text fields
    => patch sent OK

  4. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is not sent NOK
    (if you refresh the page you will see the last value that was set. Not the new one)

  5. edit a date field, press enter
    => patch is not sent NOK

C. Included tab

  1. go to e.g. sales order, create a new one and add a line

  2. edit numeric, dropdown fields, press enter
    => patch sent OK

  3. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is not sent NOK

  4. edit a date field, press enter (e.g. Product windoww, cu-tu allocation tab)
    => patch is not sent NOK

II. modal window

A. Process

  1. create a sales order, add a line, select the line

  2. go to actions, run "Create Purchase Orders"

  3. edit qty
    => patch is sent OK

  4. edit date
    => patch is not sent NOK

  5. edit a numeric field, press enter, then edit it again without leaving the field
    => patch is sent OK

B. Advanced Edit

  1. product sales order window, open advanced edit

  2. edit a numeric field or a text field, press enter, then edit it again without leaving the field
    => patch is not sent NOK

  3. edit a date field, press enter
    => patch is not sent NOK

Created follow-up for the NOKs: #1430

@metas-lc metas-lc closed this Dec 8, 2017

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 10, 2017

Update ReleaseNotpes.md
[#727](metasfresh/metasfresh-webui-api#727)
Allow search of Subproducer
[#3079](#3079) Warehouse
picking group
[#1421](metasfresh/metasfresh-webui-frontend#1421)
Drop down lists remain displayed when using tab several times
[#3150](#3150) Always
keep Terms & Conditions equal per Compensation Group
[#714](metasfresh/metasfresh-webui-api#714)
login authenticate: provide an unique key for each JSONLoginRole
[#1404](metasfresh/metasfresh-webui-frontend#1404)
login form selects 2 items from roles dropdown
[#3174](#3174) Material
Receipt Candidates not generates when using Purchase Order from Sales
Order action
[#1406](metasfresh/metasfresh-webui-frontend#1406)
Can not enter "-" into any text field
[#721](metasfresh/metasfresh-webui-api#721)
picking terminal: HUs to pick: scan/filter by Locator
[#722](metasfresh/metasfresh-webui-api#722)
picking terminal: picking slot rows shall NOT have duplicate IDs
[#3139](#3139) Cannot
edit System Administrator role (AD_Role_ID=0)
[#1396](metasfresh/metasfresh-webui-frontend#1396)
View field editor: Patch request isn't sent after hit enter
[#3171](#3171) Add view
to keep track of unprocessed async work packages
[#3149](#3149) Automatic
Discount for Group Products
[#1414](metasfresh/metasfresh-webui-frontend#1414)
view: don't allow user to sort by a given column if layout says so
[#1425](metasfresh/metasfresh-webui-frontend#1425)
eslint: increase line max-len from 80 to 120.
[#716](metasfresh/metasfresh-webui-api#716)
picking terminal: scan picking slot by barcode
[#723](metasfresh/metasfresh-webui-api#723)
picking terminal: HUs to pick: Pick CUs process
[#3137](#3137) Clean
C_PaySelection
[#3160](#3160)
C_Printing_Queue_ReEnqueue with IsSelected doesn't work
[#713](metasfresh/metasfresh-webui-api#713)
Error creating bean with name 'scopedTarget.internalUserSessionData'
[#1383](metasfresh/metasfresh-webui-frontend#1383)
cannot completely delete a numeric field in grid view
[#3138](#3138) Import
BPartner window: cannot see data
[#2340](#2340) Relation
Type: changelog
[#3151](#3151)
ZoomTo-Performance Issues
[#3147](#3147) Errors wrt
C_BPartner SQL columns
[#2338](#2338) Relation
Type: fact_accounts
[#3110](#3110) Request
All does not show records
[#1407](metasfresh/metasfresh-webui-frontend#1407)
process result: open included view: handle profileId property
[#3105](#3105) Improve
Product import process
[#711](metasfresh/metasfresh-webui-api#711)
picking terminal: additional shall support grouping lines by order
[#3058](#3058)
TableRecordId relation types to support Prefix_AD_Table_ID and
Prefix_Record_ID
[#3126](#3126) Solve
issues around standalone report / jasper service
[#1393](metasfresh/metasfresh-webui-frontend#1393)
View attributes: consider row's supportAttributes property before
querying for attributes
[#1361](metasfresh/metasfresh-webui-frontend#1361)
View field editor: make sure the field value is sent to backend before
the view is deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment