New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not enter "-" into any text field #1406

Closed
metasnw opened this Issue Dec 4, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@metasnw
Member

metasnw commented Dec 4, 2017

Is this a bug or feature request?

bug

What is the current behavior?

when you enter "-" into a text field (single or multiline) nothing happens

Which are the steps to reproduce?

  1. open partner window https://w101.metasfresh.com:8443/window/123/2156425
  2. type "-" into any text field. e.g. description
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 4, 2017

Member

also, if there is some limited set of characters allowed, pls document which are those.

Member

teosarca commented Dec 4, 2017

also, if there is some limited set of characters allowed, pls document which are those.

@metas-mk

This comment has been minimized.

Show comment
Hide comment
@metas-mk

metas-mk Dec 4, 2017

Member

@metasnw works on w101

image

edit: works with minus in num block, but not in keyboard mapping for (DE) next to shift right.

Member

metas-mk commented Dec 4, 2017

@metasnw works on w101

image

edit: works with minus in num block, but not in keyboard mapping for (DE) next to shift right.

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 6, 2017

Member

@teosarca @metas-mk
Could you explain me about the use case of COLLAPSE_INDENT & EXPAND_INDENT shortkeys?
Where can I check them?

Member

wiadev commented Dec 6, 2017

@teosarca @metas-mk
Could you explain me about the use case of COLLAPSE_INDENT & EXPAND_INDENT shortkeys?
Where can I check them?

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 6, 2017

Member

@wiadev have no idea what are those :)
can u explain a bit what are those supposed to do?

Member

teosarca commented Dec 6, 2017

@wiadev have no idea what are those :)
can u explain a bit what are those supposed to do?

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 6, 2017

Member

@teosarca
we are listening COLLAPSE_INDENT('-') and EXPAND_INDENT('+') shortkeys on document level and it's preventing keydown events on text fields.

/* POS context */
    SELECT_ALL_LEAFS: `${mod}+S`,
    EXPAND_INDENT: '+',
    COLLAPSE_INDENT: '-',

Not sure what POST context is for.
if possible, we should update to Alt+'+/-' but wanna make sure what these are for, first.

Member

wiadev commented Dec 6, 2017

@teosarca
we are listening COLLAPSE_INDENT('-') and EXPAND_INDENT('+') shortkeys on document level and it's preventing keydown events on text fields.

/* POS context */
    SELECT_ALL_LEAFS: `${mod}+S`,
    EXPAND_INDENT: '+',
    COLLAPSE_INDENT: '-',

Not sure what POST context is for.
if possible, we should update to Alt+'+/-' but wanna make sure what these are for, first.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 6, 2017

Member

ahhh, ok, those are for expanding/collapsing nodes in tree views like this one:
image

which is broken for some reason. If it's easy/hotfixable, pls do it in this task.

About number/text fields: they should allow typing "+"/"-" characters without being intercepted on upper levels.

Hope I've answered your concerns.

Member

teosarca commented Dec 6, 2017

ahhh, ok, those are for expanding/collapsing nodes in tree views like this one:
image

which is broken for some reason. If it's easy/hotfixable, pls do it in this task.

About number/text fields: they should allow typing "+"/"-" characters without being intercepted on upper levels.

Hope I've answered your concerns.

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 8, 2017

Member

Results of IT1
tested in mf15

  • "-" can be entered in a number/text field: OK
  • "-" & "+" working for expanding/collapsing nodes in tree views: OK
Member

metas-dh commented Dec 8, 2017

Results of IT1
tested in mf15

  • "-" can be entered in a number/text field: OK
  • "-" & "+" working for expanding/collapsing nodes in tree views: OK

@metas-dh metas-dh closed this Dec 8, 2017

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 10, 2017

Update ReleaseNotpes.md
[#727](metasfresh/metasfresh-webui-api#727)
Allow search of Subproducer
[#3079](#3079) Warehouse
picking group
[#1421](metasfresh/metasfresh-webui-frontend#1421)
Drop down lists remain displayed when using tab several times
[#3150](#3150) Always
keep Terms & Conditions equal per Compensation Group
[#714](metasfresh/metasfresh-webui-api#714)
login authenticate: provide an unique key for each JSONLoginRole
[#1404](metasfresh/metasfresh-webui-frontend#1404)
login form selects 2 items from roles dropdown
[#3174](#3174) Material
Receipt Candidates not generates when using Purchase Order from Sales
Order action
[#1406](metasfresh/metasfresh-webui-frontend#1406)
Can not enter "-" into any text field
[#721](metasfresh/metasfresh-webui-api#721)
picking terminal: HUs to pick: scan/filter by Locator
[#722](metasfresh/metasfresh-webui-api#722)
picking terminal: picking slot rows shall NOT have duplicate IDs
[#3139](#3139) Cannot
edit System Administrator role (AD_Role_ID=0)
[#1396](metasfresh/metasfresh-webui-frontend#1396)
View field editor: Patch request isn't sent after hit enter
[#3171](#3171) Add view
to keep track of unprocessed async work packages
[#3149](#3149) Automatic
Discount for Group Products
[#1414](metasfresh/metasfresh-webui-frontend#1414)
view: don't allow user to sort by a given column if layout says so
[#1425](metasfresh/metasfresh-webui-frontend#1425)
eslint: increase line max-len from 80 to 120.
[#716](metasfresh/metasfresh-webui-api#716)
picking terminal: scan picking slot by barcode
[#723](metasfresh/metasfresh-webui-api#723)
picking terminal: HUs to pick: Pick CUs process
[#3137](#3137) Clean
C_PaySelection
[#3160](#3160)
C_Printing_Queue_ReEnqueue with IsSelected doesn't work
[#713](metasfresh/metasfresh-webui-api#713)
Error creating bean with name 'scopedTarget.internalUserSessionData'
[#1383](metasfresh/metasfresh-webui-frontend#1383)
cannot completely delete a numeric field in grid view
[#3138](#3138) Import
BPartner window: cannot see data
[#2340](#2340) Relation
Type: changelog
[#3151](#3151)
ZoomTo-Performance Issues
[#3147](#3147) Errors wrt
C_BPartner SQL columns
[#2338](#2338) Relation
Type: fact_accounts
[#3110](#3110) Request
All does not show records
[#1407](metasfresh/metasfresh-webui-frontend#1407)
process result: open included view: handle profileId property
[#3105](#3105) Improve
Product import process
[#711](metasfresh/metasfresh-webui-api#711)
picking terminal: additional shall support grouping lines by order
[#3058](#3058)
TableRecordId relation types to support Prefix_AD_Table_ID and
Prefix_Record_ID
[#3126](#3126) Solve
issues around standalone report / jasper service
[#1393](metasfresh/metasfresh-webui-frontend#1393)
View attributes: consider row's supportAttributes property before
querying for attributes
[#1361](metasfresh/metasfresh-webui-frontend#1361)
View field editor: make sure the field value is sent to backend before
the view is deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment