New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view: singleOverlayField filters are half broken #1415

Closed
teosarca opened this Issue Dec 6, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@teosarca
Member

teosarca commented Dec 6, 2017

Is this a bug or feature request?

bug
required for metasfresh/metasfresh-webui-api#721
metasfresh/metasfresh#3078

What is the current behavior?

Which are the steps to reproduce?

  • open handling units view: https://w101.metasfresh.com:8443/window/540189
  • open filter by barcode:
    image
  • write there one of the HU Code you can see on background, on a top level row (e.g. 1000040):
    image
  • press enter => the view is filtered so now only that HU is there
  • remark: the filter button is blue which means we have an active filter there => OK
  • press on filter button again and the Barcode single overlay field is displayed again but with following issues:
    ** the textbox is empty => instead the current param value shall be displayed AND the text shall be all selected so it would be convenient for user to replace it (i.e. to scan it using barcode scanner)
    ** make sure that in case of singleOverlayField filters, if the param value is empty/null the filter is taken out => atm this is not happening all the time
    image

What is the expected or desired behavior?

Fix those 2 issues reported above.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 6, 2017

Member

** make sure that in case of singleOverlayField filters, if the param value is empty/null the filter is taken out => atm this is not happening all the time

Here is how to reproduce that one.
So after you filtered by some barcode, press on the filter button.
The overlay is displayed and the field is empty

  • in case you press enter directly=> filter is not taken out (NOK!)
  • write something in that field and then delete it, so the text box is empty and then press enter => filter is taken out (OK)
Member

teosarca commented Dec 6, 2017

** make sure that in case of singleOverlayField filters, if the param value is empty/null the filter is taken out => atm this is not happening all the time

Here is how to reproduce that one.
So after you filtered by some barcode, press on the filter button.
The overlay is displayed and the field is empty

  • in case you press enter directly=> filter is not taken out (NOK!)
  • write something in that field and then delete it, so the text box is empty and then press enter => filter is taken out (OK)
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 7, 2017

Member

@ottosichert integrated the pull request.
For "frequent" filters is working (note frequest filter is a filter which is diplayed directly on main layout and not in the "Filters" dropdown).
But for those which are not frequent it still has to be fixed.

NOTE: in the task example the screenshots were made when the HU barcode was not a frequent filter, but by mistake i've made it frequent filter.
Now i am changing it back and will do a rollout to be able to test it.

Member

teosarca commented Dec 7, 2017

@ottosichert integrated the pull request.
For "frequent" filters is working (note frequest filter is a filter which is diplayed directly on main layout and not in the "Filters" dropdown).
But for those which are not frequent it still has to be fixed.

NOTE: in the task example the screenshots were made when the HU barcode was not a frequent filter, but by mistake i've made it frequent filter.
Now i am changing it back and will do a rollout to be able to test it.

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Dec 7, 2017

Update ReleaseNotes.md
Adding a new Issue to the release notes of next week
metasfresh/metasfresh-webui-frontend#1415
View: singleOverlayField filters are half broken

@metas-dh metas-dh self-assigned this Dec 8, 2017

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 8, 2017

Member

Results of IT1
tested in mf15

  • pressing filter button again after filtering for Barcode: textbox is not empty, but the Barcode entered earlier is still displayed and the full text is selected: OK
  • pressing Enter again: same filter is applied: OK
  • delete the textbow and press Enter directly after: filter is taken out: OK
Member

metas-dh commented Dec 8, 2017

Results of IT1
tested in mf15

  • pressing filter button again after filtering for Barcode: textbox is not empty, but the Barcode entered earlier is still displayed and the full text is selected: OK
  • pressing Enter again: same filter is applied: OK
  • delete the textbow and press Enter directly after: filter is taken out: OK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment