New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3 errors on dashboard #1427

Closed
metas-lc opened this Issue Dec 8, 2017 · 22 comments

Comments

Projects
None yet
5 participants
@metas-lc

metas-lc commented Dec 8, 2017

Is this a bug or feature request?

bug

What is the current behavior?

you get flooded with errors in console when you open the dashboard

Which are the steps to reproduce?

open https://w101.metasfresh.com:8443/ see console
image

What is the expected or desired behavior?

no errors

@metas-lc metas-lc added the type:bug label Dec 8, 2017

@metas-lc metas-lc added this to the Backlog milestone Dec 8, 2017

@teosarca teosarca changed the title from errors on dashboard to d3 errors on dashboard Dec 8, 2017

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 9, 2017

Member

@teosarca @metas-lc
can't reproduce the error anymore.

Also, I found another issue while I'm playing around.

screenshot at dec 09 21-16-43

Member

wiadev commented Dec 9, 2017

@teosarca @metas-lc
can't reproduce the error anymore.

Also, I found another issue while I'm playing around.

screenshot at dec 09 21-16-43

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 13, 2017

Member

@teosarca the reason for this is we are getting negative values (less than 0) from the backend.
screenshot at dec 13 17-40-43

How does it work? are we supposed to have negative values, as well?

Member

wiadev commented Dec 13, 2017

@teosarca the reason for this is we are getting negative values (less than 0) from the backend.
screenshot at dec 13 17-40-43

How does it work? are we supposed to have negative values, as well?

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 13, 2017

Member

@wiadev 10x. I think this shall be handled on backend side and in case of pie charts always send positive numbers.

Member

teosarca commented Dec 13, 2017

@wiadev 10x. I think this shall be handled on backend side and in case of pie charts always send positive numbers.

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 13, 2017

Member

@teosarca cool
FYI, it's not pie charts but bar charts are causing the issues.

Member

wiadev commented Dec 13, 2017

@teosarca cool
FYI, it's not pie charts but bar charts are causing the issues.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 13, 2017

Member

@wiadev hmm, but on bar charts we shall be able to display negative numbers, isn't it?

Member

teosarca commented Dec 13, 2017

@wiadev hmm, but on bar charts we shall be able to display negative numbers, isn't it?

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 13, 2017

Member

@teosarca we can draw negative values below the x-axis but at the moment, negative values are setting for heights.
height should be positive and y(position) should be changed.

do you want me to check?
and my question was if we were supposed to get negative values for bar charts.(e.g products)

Member

wiadev commented Dec 13, 2017

@teosarca we can draw negative values below the x-axis but at the moment, negative values are setting for heights.
height should be positive and y(position) should be changed.

do you want me to check?
and my question was if we were supposed to get negative values for bar charts.(e.g products)

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 13, 2017

Member

do you want me to check?

yes pls

and my question was if we were supposed to get negative values for bar charts.(e.g products)

depends on each bar chart, but i don't see why not.

Member

teosarca commented Dec 13, 2017

do you want me to check?

yes pls

and my question was if we were supposed to get negative values for bar charts.(e.g products)

depends on each bar chart, but i don't see why not.

@metas-ts

This comment has been minimized.

Show comment
Hide comment
@metas-ts

metas-ts Dec 14, 2017

Member

i can also see a number of interesting cases for negative bar charts (scnr)

Member

metas-ts commented Dec 14, 2017

i can also see a number of interesting cases for negative bar charts (scnr)

wiadev added a commit that referenced this issue Dec 15, 2017

wiadev added a commit that referenced this issue Dec 15, 2017

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 15, 2017

Member

@teosarca
screenshot at dec 15 01-07-59
you can hardly see it because the offset(negative number) -6.9 vs 64000(max).

FYI, I've added additional x-axis at y:0 if there is a negative value to make it more visible.

Member

wiadev commented Dec 15, 2017

@teosarca
screenshot at dec 15 01-07-59
you can hardly see it because the offset(negative number) -6.9 vs 64000(max).

FYI, I've added additional x-axis at y:0 if there is a negative value to make it more visible.

teosarca added a commit that referenced this issue Dec 15, 2017

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 16, 2017

Member

did a quick test: open the dashboard and look at that barchat with negative numbers.
Each time it's refreshed (atm it's configured each second) the barchart is animated, even there was NO change => NOK

image

image

Member

teosarca commented Dec 16, 2017

did a quick test: open the dashboard and look at that barchat with negative numbers.
Each time it's refreshed (atm it's configured each second) the barchart is animated, even there was NO change => NOK

image

image

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 18, 2017

Update ReleaseNotes.md
[#706](metasfresh/metasfresh-webui-api#706)
Port current MRP Product Info Window to the webui
[#755](metasfresh/metasfresh-webui-api#755)
Processes: support for parentViewSelectedIds and childViewSelectedIds
[#1427](metasfresh/metasfresh-webui-frontend#1427)
d3 errors on dashboard
[#2646](#2646) MRP
Product Info Just in Time
[#751](metasfresh/metasfresh-webui-api#751)
Picking Tray Clearing: packing HUs: Add to Transportation Order action
[#1437](metasfresh/metasfresh-webui-frontend#1437)
Language bug: The language in Settings is not respected
[#746](metasfresh/metasfresh-webui-api#746)
Picking Tray Clearing: Scan picking slot barcode filter
[#1455](metasfresh/metasfresh-webui-frontend#1455)
error when updating an attribute multiple times
[#747](metasfresh/metasfresh-webui-api#747)
Picking Tray Clearing: filter picking slots by Partner
[#1433](metasfresh/metasfresh-webui-frontend#1433)
Support Lookup view attributes
[#3211](#3211) Picking
Tray Clearing: right side view shall display only the HUs for current
BP/Location
[#1444](metasfresh/metasfresh-webui-frontend#1444)
Attributes are empty in material receipt candidate
[#3202](#3202) Error in
Paymentjournal Process/ Report in Payselection
[#3193](#3193) Improve
Window for manual OnHand Qty in WebUI
[#1448](metasfresh/metasfresh-webui-frontend#1448)
jenkins: fix current lint issues
[#1435](metasfresh/metasfresh-webui-frontend#1435)
Problem regarding multiple filters
[#1436](metasfresh/metasfresh-webui-frontend#1436)
Remove legacy docs
[#3169](#3169) Updating
PMM_Week availability trend fails
[#1206](metasfresh/metasfresh-webui-frontend#1206)
Use automatic code style enforcement
[#717](metasfresh/metasfresh-webui-api#717)
picking terminal: open HUs to pick shall display Best Before date and
Locator

me-45
@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Dec 21, 2017

Member

@teosarca is it refreshed every second? on my end, it's refreshed very occasionally.
Also, we set the animation in d3 library and we are not keeping the previous data. so we don't know if data was changed or not.

Member

wiadev commented Dec 21, 2017

@teosarca is it refreshed every second? on my end, it's refreshed very occasionally.
Also, we set the animation in d3 library and we are not keeping the previous data. so we don't know if data was changed or not.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 22, 2017

Member

@wiadev but it's weird that only for this one is happening. All the others, AFAIK, are moving nicely when data is changed.

Member

teosarca commented Dec 22, 2017

@wiadev but it's weird that only for this one is happening. All the others, AFAIK, are moving nicely when data is changed.

wiadev added a commit that referenced this issue Dec 30, 2017

metas-mk added a commit that referenced this issue Jan 2, 2018

Merge pull request #1474 from metasfresh/dev-1427
Fix re-rendering issue on BarChart #1427
@metas-mk

This comment has been minimized.

Show comment
Hide comment
@metas-mk

metas-mk Jan 2, 2018

Member

Quick test before merge
image

Member

metas-mk commented Jan 2, 2018

Quick test before merge
image

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Jan 3, 2018

Member

@metas-mk we need a barchart with negative values in order to test the feature.

note to IT: try to create some negative sales orders or something just to have an negative revenue for some of those products.

Member

teosarca commented Jan 3, 2018

@metas-mk we need a barchart with negative values in order to test the feature.

note to IT: try to create some negative sales orders or something just to have an negative revenue for some of those products.

@metas-lc metas-lc self-assigned this Jan 9, 2018

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Jan 9, 2018

IT
created/completed a sales order with qty -100
checked dashboard: looks like this (NOK)
image
rest is ok: no refreshing and no errors (OK)

metas-lc commented Jan 9, 2018

IT
created/completed a sales order with qty -100
checked dashboard: looks like this (NOK)
image
rest is ok: no refreshing and no errors (OK)

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Jan 9, 2018

Member

@metas-lc confirmed on w101. leave the negative values as it is while I'm working, please.

Member

wiadev commented Jan 9, 2018

@metas-lc confirmed on w101. leave the negative values as it is while I'm working, please.

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Jan 9, 2018

@wiadev btw i think on w101 the task is not rolled out. I was testing somewhere else. I won't change the values on w101. Let me know if you need rollout

metas-lc commented Jan 9, 2018

@wiadev btw i think on w101 the task is not rolled out. I was testing somewhere else. I won't change the values on w101. Let me know if you need rollout

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Jan 9, 2018

Member

@metas-lc even though you didn't roll out, you updated the w101 DB to have negative values to test, right?

Member

wiadev commented Jan 9, 2018

@metas-lc even though you didn't roll out, you updated the w101 DB to have negative values to test, right?

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Jan 9, 2018

@wiadev yes, i wanted to confirm it's a bug. But then i noticed it doesn't look like it was rolled out. You can remove the order i did: https://w101.metasfresh.com:8443/window/143/1000297
from now on, i won't change numbers :)

metas-lc commented Jan 9, 2018

@wiadev yes, i wanted to confirm it's a bug. But then i noticed it doesn't look like it was rolled out. You can remove the order i did: https://w101.metasfresh.com:8443/window/143/1000297
from now on, i won't change numbers :)

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Jan 9, 2018

Member

@metas-lc no I need those numbers so I can reproduce on my end, as well. :) all good. leave them, please.

Member

wiadev commented Jan 9, 2018

@metas-lc no I need those numbers so I can reproduce on my end, as well. :) all good. leave them, please.

wiadev added a commit that referenced this issue Jan 10, 2018

@wiadev

This comment has been minimized.

Show comment
Hide comment
@wiadev

wiadev Jan 10, 2018

Member

@metas-lc can you roll out this on w101 and test again?

Member

wiadev commented Jan 10, 2018

@metas-lc can you roll out this on w101 and test again?

wiadev added a commit that referenced this issue Jan 10, 2018

metas-mk added a commit that referenced this issue Jan 13, 2018

Merge pull request #1497 from metasfresh/dev-1427
Fix drawing bars for negative values #1427
@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Jan 16, 2018

IT
checked again, looks fine and there are no errors

metas-lc commented Jan 16, 2018

IT
checked again, looks fine and there are no errors

@metas-lc metas-lc closed this Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment