New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown in Grid view needs two-time click again #1440

Closed
metas-dh opened this Issue Dec 12, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@metas-dh
Member

metas-dh commented Dec 12, 2017

Is this a bug or feature request?

Bug

What is the current behavior?

If there are >1 values in dropdown list, you need to click two times for selection.

Which are the steps to reproduce?

see #1347: was already fixed there, but is happening again

What is the expected or desired behavior?

Should work the first time.

@PabloSichert

This comment has been minimized.

Show comment
Hide comment
@PabloSichert

PabloSichert Dec 15, 2017

Contributor

This has most likely been reintroduced by #1432

Contributor

PabloSichert commented Dec 15, 2017

This has most likely been reintroduced by #1432

PabloSichert added a commit that referenced this issue Dec 15, 2017

Only consider onBlur event when component was entered by handleClick
Otherwise, onBlur fires and unmounts dropdown items before handleSelect can be triggered.

Issue #1347 and #1440
@PabloSichert

This comment has been minimized.

Show comment
Hide comment
@PabloSichert

PabloSichert Dec 15, 2017

Contributor

Note to IT:

  • Make sure #1421 did not break with this change
Contributor

PabloSichert commented Dec 15, 2017

Note to IT:

  • Make sure #1421 did not break with this change
@metas-mk

This comment has been minimized.

Show comment
Hide comment
@metas-mk

metas-mk Dec 15, 2017

Member

@PabloSichert quick test. the fix breaks #1421 again
image

Member

metas-mk commented Dec 15, 2017

@PabloSichert quick test. the fix breaks #1421 again
image

PabloSichert added a commit that referenced this issue Dec 22, 2017

Only consider onBlur event when component was entered by handleClick
Otherwise, onBlur fires and unmounts dropdown items before handleSelect can be triggered.

Issue #1347 and #1440

PabloSichert added a commit that referenced this issue Dec 22, 2017

PabloSichert added a commit that referenced this issue Dec 22, 2017

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Dec 22, 2017

Update ReleaseNotes.md
Adding new issue to release notes
metasfresh/metasfresh-webui-frontend#1440
Dropdown in Grid view needs two-time click again

metas-ts added a commit that referenced this issue Dec 22, 2017

Only consider onBlur event when component was entered by handleClick
Otherwise, onBlur fires and unmounts dropdown items before handleSelect can be triggered.

Issue #1347 and #1440

(cherry picked from commit 0365937)

metas-ts added a commit that referenced this issue Dec 22, 2017

metas-ts added a commit that referenced this issue Dec 22, 2017

@metas-dh metas-dh self-assigned this Jan 8, 2018

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Jan 8, 2018

Member

Results of IT1
tested in last weekly release e2e

  • Dropdown in Grid view: selection works the first time: OK
  • Dropdown lists do not remain displayed after losing focus: OK
Member

metas-dh commented Jan 8, 2018

Results of IT1
tested in last weekly release e2e

  • Dropdown in Grid view: selection works the first time: OK
  • Dropdown lists do not remain displayed after losing focus: OK
@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Jan 9, 2018

Member

Update: also worked fine in this week's e2e.

Member

metas-dh commented Jan 9, 2018

Update: also worked fine in this week's e2e.

@metas-dh metas-dh closed this Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment