Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Errors in the console when opening HU Editor #1559

Closed
siemiatj opened this issue Feb 6, 2018 · 5 comments
Closed

Errors in the console when opening HU Editor #1559

siemiatj opened this issue Feb 6, 2018 · 5 comments

Comments

@siemiatj
Copy link
Contributor

siemiatj commented Feb 6, 2018

Is this a bug or feature request?

Bug

What is the current behavior?

When opening HU Editor window, there are errors in the console.

Which are the steps to reproduce?

Open any HU Editor window (or go to http://localhost:3000/window/540189). Errors should be immediately visible. Clicking on the table rows produces more errors.

image pasted at 2018-2-5 18-46

console :

Uncaught (in promise) TypeError: Cannot read property 'fieldsByName' of undefined
at then.response (bundled7794b0f8da2e8536f50.js:50132)
at <anonymous>

What is the expected or desired behavior?

No errors in the console being thrown.

@metas-mk
Copy link
Member

metas-mk commented Feb 6, 2018

@siemiatj is this issue needed for this weeks release? if not I would propose to leave it in our master branch this week and it will be automatically in next week's release.

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Feb 6, 2018
Adding a new Issue
metasfresh/metasfresh-webui-frontend-legacy#1559
Errors in the console when opening HU Editor
@siemiatj
Copy link
Contributor Author

siemiatj commented Feb 6, 2018

Not sure. Depends on @metas-dh probably ?

@teosarca
Copy link
Member

teosarca commented Feb 6, 2018

agree.

btw, we use branch:release to signal that the task was integrated/cherry-picked(CPed) to release branch.
That usually happens after integration testing (IT).
If you want to tell to testing team/release manager that a certain task shall be part of next release then use branch:release-TODO or branch:release-TODO-after-IT.

Similarly, we use branch:master to to tag those issues which were integrated to master branch (i.e. PR was merged).

@metas-dh
Copy link
Member

metas-dh commented Feb 6, 2018

imho we don't need it for this week's release; since the error's only popping up in console and not bothering the user in any way, i guess it's ok to have it in next week's release.

@metas-lc
Copy link

metas-lc commented Feb 6, 2018

IT
checked window Handling Unit Editor, selected some HUs => no errors OK
checked HU editor from receipt candidates. Selected some HU lines => no errors OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants