Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make window tabs cypress friendly #1926

Closed
teosarca opened this issue Aug 21, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@teosarca
Copy link
Member

commented Aug 21, 2018

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

When generating window included tabs, use the "internalName" from layout as widget/element/div IDs.
Or something similar, just to be able to identify those tabs in cypress by their "internalName".

Backend task: metasfresh/metasfresh#4491
The concept was described in metasfresh/metasfresh-webui-api#1023

@teosarca

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2018

@metas-ts @siemiatj feel free to add more to the concept.

@metas-ts

This comment has been minimized.

Copy link
Member

commented Aug 31, 2018

I think over time the API might return InternalNames for a range of different things..like (Doc)Actions, Fields, MenuItems etc
therefore it would be nice to come up with a schema that makes sure we don't need to find a different spot for the respective InternalName string each time.

Also, the InternalName is unique among all tabs of the current window. But might not be unique among all process-actions, menu-tree-items, fields, tabs etc on the respective page.

therefore i suggest to embedd not just the internal name string itself, but someting like tab_<internal-name>.

siemiatj added a commit that referenced this issue Sep 18, 2018

siemiatj added a commit that referenced this issue Sep 18, 2018

siemiatj added a commit that referenced this issue Sep 19, 2018

siemiatj added a commit that referenced this issue Sep 19, 2018

- custom cypress command to work with tabs #1926
- use tabs command in test to be sure it works #1926

siemiatj added a commit that referenced this issue Sep 19, 2018

- custom cypress command to work with tabs #1926
- use tabs command in test to be sure it works #1926

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Sep 20, 2018

Update ReleaseNotes.md
Adds new Issue
metasfresh/metasfresh-webui-frontend#1926
Make window tabs cypress friendly

metas-dh added a commit that referenced this issue Sep 25, 2018

#1926 Make window tabs cypress friendly
cypress test for IT
@metas-dh

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

Results of IT1
tested in dev120

  1. created cypress test to open tab "Location" in window bpartner, using the internal name, resp. ID: "tab_Window-123-222"
  2. ran test on dev120: tab "Location" was opened correctly: OK
  3. also working when internal name is e.g. "tab_Customer" (Customer tab in window bpartner): OK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.