Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts not working properly in Tabs after changing sth in grid view + [Tab] #1949

Open
metas-dh opened this issue Sep 3, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@metas-dh
Copy link
Member

commented Sep 3, 2018

Is this a bug or feature request?

Bug

What is the current behavior?

When you have changed sth in a tab, in grid view, shortcuts like e.g. alt+e or alt+y don't work anymore.

Which are the steps to reproduce?

  1. Open bpartner window/123,for e.g. Test Kunde, select location tab
  2. try alt+e: advanced edit opens: OK
  3. try alt+y: modal opens if you want to delete data: OK
  4. change sth in the grid view, e.g. name of the location, use Tab
  5. try the shortcuts again:
  • [alt]+y: console: bundle-68a8b26b41afac1887dc-git-88660db.js:77 Handler defined for key sequence "ALT+Y" is not a function.: NOK
  • alt+e: advanced edit for the header opens: NOK

http://recordit.co/2Fmf9l1aCq

=> works fine when you change sth in advanced edit
=> when you use Enter after the change you made, alt+y works fine, but alt+e also opens the advanced edit for the header

=> also happened in sales order, when i changed sth in orderline

What is the expected or desired behavior?

@metas-dh metas-dh added the type:bug label Sep 3, 2018

@siemiatj siemiatj self-assigned this Sep 17, 2018

@siemiatj

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

imho we almost have no bugs here. Simply Table shortcuts work only when something is selected, and window shortcuts when something isn't. One bug I've found is when opening window, going to locations (or other tab with results) and clicking [alt]+y. This triggers a delete without anything to delete. Other than that :

  • to get the [alt]+e working just deselect rows (by changing tabs for example),
  • to get the [alt]+y working, select a row

siemiatj added a commit that referenced this issue Sep 17, 2018

siemiatj added a commit that referenced this issue Sep 17, 2018

siemiatj added a commit that referenced this issue Sep 17, 2018

@metas-dh

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2018

checked with metas-mk:
=> In my case, it's confusing when after e.g. changing the name of a location, in baprtner window, the row in location tab is still selected (or at least looks like it is), but the [alt]+e does not open advanced edit for this line. Of course the user could deselect rows / change tabs and then select and use [alt]+e once more for the row where they made changes, but it's not very intuitive / not very nice.
However, this is not high prio at all, so pls leave it for when there are no more urgent tasks, and pls do an estimation before getting back to this task so we can decide if it's worth the effort.

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Sep 20, 2018

Update ReleaseNotes.md
Adds new Issue
metasfresh/metasfresh-webui-frontend#1949
Shortcuts not working properly in Tabs after changing sth in grid
view + [Tab]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.