Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support active indication for filters without parameters #1972

Closed
siemiatj opened this issue Sep 20, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@siemiatj
Copy link
Contributor

commented Sep 20, 2018

Is this a bug or feature request?

Bug

What is the current behavior?

Filters without parameters are not properly indicated as active.

Which are the steps to reproduce?

Find any filter without parameters and click Apply.

What is the expected or desired behavior?

Filter button should show active state and filter name/caption.

@siemiatj siemiatj self-assigned this Sep 20, 2018

siemiatj added a commit that referenced this issue Sep 20, 2018

- add caption of filter without paraeters to captions array #1972
- define local filter on apply if not available #1972

siemiatj added a commit that referenced this issue Sep 20, 2018

siemiatj added a commit that referenced this issue Sep 20, 2018

@siemiatj siemiatj added the type:bug label Sep 21, 2018

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Sep 25, 2018

Update ReleaseNotes.md
Adds new Issue
metasfresh/metasfresh-webui-frontend#1972
Support active indication for filters without parameters
@metas-dh

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

Results of IT1
tested in mf15

filters without parameters working fine: e.g. user queries in printing queue:

  • filter works fine when applied, results are correct: OK
  • filter is labeled correctly (e.g. Abrechnung_offen_normal, as it is selectable): OK

@metas-dh metas-dh closed this Sep 27, 2018

metas-ts added a commit that referenced this issue Sep 28, 2018

- add caption of filter without paraeters to captions array #1972
- define local filter on apply if not available #1972

(cherry picked from commit cd624ec)

metas-ts added a commit that referenced this issue Sep 28, 2018

metas-ts added a commit that referenced this issue Sep 28, 2018

- properly hide the Apply button #1972
(cherry picked from commit 8a8746f)
@metas-ts

This comment has been minimized.

Copy link
Member

commented Sep 28, 2018

🍒 picked #1972 to release

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 28, 2018

Update ReleaseNotes.md
[#4622](#4622) Requests can not be saved II
[#4624](#4624) Invoice candidate not updated after shipment reactivate and complete
[#1972](metasfresh/metasfresh-webui-frontend#1972) Support active indication for filters without parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.