Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut shall work for Cancel button in Modal view #2180

Closed
metas-dh opened this issue Feb 13, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@metas-dh
Copy link
Member

commented Feb 13, 2019

Is this a bug or feature request?

FR

What is the current behavior?

Atm, Esc shortcut does not work in the modal overlay for Product proposal, although the tooltip is displayed. Other shortcuts like Alt + Enter are working fine.

2019-02-13 14_27_26-metasfresh

Which are the steps to reproduce?

Try and see.

What is the expected or desired behavior?

Esc shortcut shall work.

siemiatj added a commit that referenced this issue Apr 22, 2019

@siemiatj siemiatj self-assigned this Apr 22, 2019

siemiatj added a commit that referenced this issue Apr 22, 2019

siemiatj added a commit that referenced this issue Apr 22, 2019

- generate shortcuts dynamically #2180
- fix showing tooltips
@metas-dh

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Results of IT1
tested in mf15

  • Esc now working for Cancel button in Modal view (Product Proposal): OK
  • Esc still working for Cancel button in main windows (e.g. deleting sales order, single & grid view), and tabs (e.g. deleting order lines, product prices): OK

@metas-dh metas-dh closed this Apr 24, 2019

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 28, 2019

update ReleaseNotes.md
  * [#5151](#5151) Allow to delete Scale Prices
  * [#5157](#5157) Reduce log-output of sequence checks when running migration-script
  * [#2180](metasfresh/metasfresh-webui-frontend#2180) Shortcut shall work for Cancel button in Modal view
  * [#2195](metasfresh/metasfresh-webui-frontend#2195) Tab top actions: use provided shortcut if any
  * [#53](metasfresh/metasfresh-e2e#53) Add repeatable actions for working with filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.