Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button for modals #2182

Closed
siemiatj opened this issue Feb 15, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@siemiatj
Copy link
Contributor

commented Feb 15, 2019

Is this a bug or feature request?

Feature

What is the current behavior?

Modals have no back button functionality

Which are the steps to reproduce?

Open any modal and see.

What is the expected or desired behavior?

Modals should have a back button, that uses parentWindowId and parentViewId to navigate back.

@siemiatj siemiatj self-assigned this Feb 15, 2019

siemiatj added a commit that referenced this issue Feb 18, 2019

- support Back button action #2182
- rewrite some event handlers to prevent unnecessary re-renders

teosarca added a commit to metasfresh/metasfresh that referenced this issue Feb 18, 2019

@metas-dh

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Results of IT1
tested in mf15

  • Back button in modal view, More products...: OK
  • pressing the Back button closes the More products..., user gets back to Products Proposal: OK
  • Back option in quick actions: shall be taken out in metasfresh/metasfresh-webui-api#1154

@metas-dh metas-dh closed this Feb 21, 2019

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Feb 25, 2019

update ReleaseNotes.md
  * [#4967](#4967) Warehouse Customization: Picking
  * [#1154](metasfresh/metasfresh-webui-api#1154) Take out "Back" action from quick actions in "More products..." modal
  * [#1155](metasfresh/metasfresh-webui-api#1155) Support providing shortcuts for processes
  * [#2182](metasfresh/metasfresh-webui-frontend#2182) Back button for modals
  * [#2183](metasfresh/metasfresh-webui-frontend#2183) frontend: Scan using camera shall be translatable
  * [#2193](metasfresh/metasfresh-webui-frontend#2193) View quick actions: provide viewProfileId when calling /quickActions endpoint
  * [#4964](#4964) Services.get(IDocumentNoBuilderFactory.class) calls the wrong constructor
  * [#4976](#4976) M_DiscountSchemaBreak.PriceBase shall be nullable
  * [#57](metasfresh/metasfresh-dist#57) PostgreSQL applying our migration scripts not working anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.