Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation popup before deleting attachment file #2287

Open
siemiatj opened this issue May 31, 2019 · 2 comments

Comments

Projects
None yet
5 participants
@siemiatj
Copy link
Contributor

commented May 31, 2019

Is this a bug or feature request?

Feature

What is the current behavior?

What is the expected or desired behavior?

We want to add a confirmation modal when user is about to delete an attachment file. Permissions to delete files will be controlled by a new role/flag from the backend, so this will have to wait for the backend changes. Ask @cristinastefan90 for details.

@cristinastefan90

This comment has been minimized.

Copy link

commented Jun 4, 2019

Expected behaviour/Steps to reproduce:

A new flag allowDelete was introduced in order to control the deletion of attachments.
This can be set from Role window - IsAttachmentDeletionAllowed
image

The desired behaviour for removing the attachments based on this flag is the following:

  1. Navigate to Role - pick one
    image

2.Go to the menu on the right side and navigate to attachments:
image

  1. In Chrome developer tools go to Network -> attachments request -> Preview
    image

If 'allowDelete' is false -> remove attachment symbol should not be visible
If 'allowDelete' is true -> remove attachment symbol should be visible and the removal should be possible.
image

4.When the removal is possible, after pressing on the remove symbol, a new popup should appear asking the user "Do you want to delete" Y/N

@metas-ts

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

"Do you want to delete"

@cristinastefan90 for the actual message text, I think you need to settle for an AD_Messge with Kuba (this is similar to the "Download" AD_Messge from yesterday)

@oliviupis oliviupis referenced this issue Jun 7, 2019

Merged

Dev 2287 #2298

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jun 10, 2019

update ReleaseNotes.md
  * [#5204](#5204) On-the-fly auto-allocate available HUs while creating shipments
  * [#5208](#5208) Attribute Age automatism
  * [#5210](#5210) Customs Document
  * [#5231](#5231) Import Replenishments
  * [#5237](#5237) Attribute "Herkunft" is not updated after country change
  * [#5238](#5238) Finetuning Area Search: Params from selected BPartner>>Location
  * [#5239](#5239) Jasper for Customs Invoice
  * [#5261](#5261) Prevent Users from Accidentally deleting attachment files
  * [#5262](#5262) Adjustments for Specifications
  * [#5265](#5265) Show different Bestellkontrolle views in Jasper based on type
  * [#5276](#5276) Finetuning dunning window
  * [#5282](#5282) WARN if webui.frontend.url is not configured
  * [#5285](#5285) Make sure AD_Column.IsTranslatable could be set when the column is eligible
  * [#5288](#5288) customization tool: Process to add/update a field to selected UI element group
  * [#5290](#5290) Fix BPartner->Vendor wrong tab name
  * [#5291](#5291) automated test: make sure RepoIds are correctly defined
  * [#2284](metasfresh/metasfresh-webui-frontend#2284) Make OpenViewAction open data in a new browser tab
  * [#2287](metasfresh/metasfresh-webui-frontend#2287) Add a confirmation popup before deleting attachment file
  * [#5280](#5280) Enable MetasfreshIssueAppender when the system is ready for it
  * [#5284](#5284) Non-Barcode Order-Checkup doesn't show C_BPartner_Location.Name
  * [#1206](metasfresh/metasfresh-webui-api#1206) HU Transform and Serial Number Processes don't start
  * [#2149](metasfresh/metasfresh-webui-frontend#2149) Decimal value .00 not added to product price at first
  * [#2232](metasfresh/metasfresh-webui-frontend#2232) Wrong Button color after first Date click in Range Widget
  * [#2274](metasfresh/metasfresh-webui-frontend#2274) Calendar icon should react to clicks
  * [#2279](metasfresh/metasfresh-webui-frontend#2279) Patching broken for Attributes widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.